Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2814623002: Add //content/test:test_runner_support deps on //content/public/renderer (Closed)

Created:
3 years, 8 months ago by mattm
Modified:
3 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add //content/test:test_runner_support deps on //content/public/renderer test_runner_support.cc includes content/renderer/render_frame_impl.h which includes content/public/common/referrer.h which includes net/ headers. Depending on //content/public/renderer gets its public_deps for net. BUG=none Review-Url: https://codereview.chromium.org/2814623002 Cr-Commit-Position: refs/heads/master@{#463469} Committed: https://chromium.googlesource.com/chromium/src/+/6b0f538afa82922e2abb7880418fb75320275b26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mattm
3 years, 8 months ago (2017-04-10 23:45:46 UTC) #6
brettw
lgtm
3 years, 8 months ago (2017-04-10 23:48:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814623002/1
3 years, 8 months ago (2017-04-10 23:52:27 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 00:43:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b0f538afa82922e2abb7880418f...

Powered by Google App Engine
This is Rietveld 408576698