🔍 Continue working on the search widget prototype

🔍 Continue working on the search widget prototype

General cleanup:
* Further encapsulate the SearchActivityLocationBarLayout.

* Enable the search widget on Canary so that we can get
  _some_ testing.

Microphone fixes:
* Switch to singleTask so that the microphone works on JB
  and KK: Android changed semantics for
  startActivityForResult for singleInstance tasks somewhere
  after that.  We were already properly handling singleTask
  behavior because of the onNewIntent call anyway.

* Hook into Activity#onRequestPermissionsResult so that
  we can properly listen for permissions changes and trigger
  a voice query afterward.

* If we're not confident in the search query, the result is
  put into the text box.  Hitting enter previously sent you
  to the first link in the suggestions instead of properly
  regenerating them.  This was fixed by avoiding trying to
  refocus and reset the query when the microphone result
  came in.

Transition fixes:
* Stop calling finish() from onStop().  This messed up when
  the user went to recents and then re-entered the
  SearchActivity immediately.

* Clean up some more of the activity creation, including
  getting rid of an unnecessary style.  This fixes up
  some of the background color transitions slightly.

BUG=708844
Review-Url: https://codereview.chromium.org/2814593003
Cr-Commit-Position: refs/heads/master@{#463715}
Committed: https://chromium.googlesource.com/chromium/src/+/24f29cd501c22986c8b80fbf4283c734be81c2b9

[gone, 2017-04-11 01:05:04]

dfalcantara@chromium.org changed reviewers:
+ yusufo@chromium.org

[gone, 2017-04-11 01:05:11]

Description was changed from

==========
🔍 Continue cleaning up the search widget.

* Fix up some of the transitions between Activities.

* Further encapsulate the SearchActivityLocationBarLayout.

* Clean up some more of the activity creation, including getting rid of an
  unnecessary style.

* Enable the search widget on Canary.

BUG=708844
==========

to

==========
🔍 Continue cleaning up the search widget

* Fix up some of the transitions between Activities.

* Further encapsulate the SearchActivityLocationBarLayout.

* Clean up some more of the activity creation, including getting rid of an
  unnecessary style.

* Enable the search widget on Canary.

BUG=708844
==========

[gone, 2017-04-11 04:51:51]

Description was changed from

==========
🔍 Continue cleaning up the search widget

* Fix up some of the transitions between Activities.

* Further encapsulate the SearchActivityLocationBarLayout.

* Clean up some more of the activity creation, including getting rid of an
  unnecessary style.

* Enable the search widget on Canary.

BUG=708844
==========

to

==========
🔍 Continue cleaning up the search widget prototype

* Fix up some of the transitions between Activities.

* Further encapsulate the SearchActivityLocationBarLayout.

* Clean up some more of the activity creation, including
  getting rid of an unnecessary style.

* Switch to singleTask so that the microphone works on JB
  and KK: Android changed semantics for
  startActivityForResult for singleInstance tasks somewhere
  after that.  We were already properly handling singleTask
  behavior because of the onNewIntent call anyway.

* Enable the search widget on Canary.

BUG=708844
==========

[gone, 2017-04-11 06:00:03]

Description was changed from

==========
🔍 Continue cleaning up the search widget prototype

* Fix up some of the transitions between Activities.

* Further encapsulate the SearchActivityLocationBarLayout.

* Clean up some more of the activity creation, including
  getting rid of an unnecessary style.

* Switch to singleTask so that the microphone works on JB
  and KK: Android changed semantics for
  startActivityForResult for singleInstance tasks somewhere
  after that.  We were already properly handling singleTask
  behavior because of the onNewIntent call anyway.

* Enable the search widget on Canary.

BUG=708844
==========

to

==========
🔍 Continue cleaning up the search widget prototype

General cleanup:
* Further encapsulate the SearchActivityLocationBarLayout.

* Enable the search widget on Canary so that we can get
  _some_ testing.

Permissions fixes:
* Switch to singleTask so that the microphone works on JB
  and KK: Android changed semantics for
  startActivityForResult for singleInstance tasks somewhere
  after that.  We were already properly handling singleTask
  behavior because of the onNewIntent call anyway.

* Hook into Activity#onRequestPermissionsResult so that
  we can properly listen for permissions changes and trigger
  a voice query afterward.

Transition fixes:
* Stop calling finish() from onStop().  This messed up when
  the user went to recents and then re-entered the
  SearchActivity immediately.

* Clean up some more of the activity creation, including
  getting rid of an unnecessary style.  This fixes up
  some of the background color transitions slightly.

BUG=708844
==========

[gone, 2017-04-11 06:00:19]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org

[gone, 2017-04-11 06:00:19]

+ted for permissions additions

[gone, 2017-04-11 06:06:20]

Description was changed from

==========
🔍 Continue cleaning up the search widget prototype

General cleanup:
* Further encapsulate the SearchActivityLocationBarLayout.

* Enable the search widget on Canary so that we can get
  _some_ testing.

Permissions fixes:
* Switch to singleTask so that the microphone works on JB
  and KK: Android changed semantics for
  startActivityForResult for singleInstance tasks somewhere
  after that.  We were already properly handling singleTask
  behavior because of the onNewIntent call anyway.

* Hook into Activity#onRequestPermissionsResult so that
  we can properly listen for permissions changes and trigger
  a voice query afterward.

Transition fixes:
* Stop calling finish() from onStop().  This messed up when
  the user went to recents and then re-entered the
  SearchActivity immediately.

* Clean up some more of the activity creation, including
  getting rid of an unnecessary style.  This fixes up
  some of the background color transitions slightly.

BUG=708844
==========

to

==========
🔍 Continue working on the search widget prototype

General cleanup:
* Further encapsulate the SearchActivityLocationBarLayout.

* Enable the search widget on Canary so that we can get
  _some_ testing.

Permissions fixes:
* Switch to singleTask so that the microphone works on JB
  and KK: Android changed semantics for
  startActivityForResult for singleInstance tasks somewhere
  after that.  We were already properly handling singleTask
  behavior because of the onNewIntent call anyway.

* Hook into Activity#onRequestPermissionsResult so that
  we can properly listen for permissions changes and trigger
  a voice query afterward.

Transition fixes:
* Stop calling finish() from onStop().  This messed up when
  the user went to recents and then re-entered the
  SearchActivity immediately.

* Clean up some more of the activity creation, including
  getting rid of an unnecessary style.  This fixes up
  some of the background color transitions slightly.

Broken stuff I just noticed:
- If we're not confident in the search query, the result is
  put into the text box.  Hitting enter just sends you to
  the homepage instead of trying to trigger the query.

BUG=708844
==========

[gone, 2017-04-11 06:32:38]

Description was changed from

==========
🔍 Continue working on the search widget prototype

General cleanup:
* Further encapsulate the SearchActivityLocationBarLayout.

* Enable the search widget on Canary so that we can get
  _some_ testing.

Permissions fixes:
* Switch to singleTask so that the microphone works on JB
  and KK: Android changed semantics for
  startActivityForResult for singleInstance tasks somewhere
  after that.  We were already properly handling singleTask
  behavior because of the onNewIntent call anyway.

* Hook into Activity#onRequestPermissionsResult so that
  we can properly listen for permissions changes and trigger
  a voice query afterward.

Transition fixes:
* Stop calling finish() from onStop().  This messed up when
  the user went to recents and then re-entered the
  SearchActivity immediately.

* Clean up some more of the activity creation, including
  getting rid of an unnecessary style.  This fixes up
  some of the background color transitions slightly.

Broken stuff I just noticed:
- If we're not confident in the search query, the result is
  put into the text box.  Hitting enter just sends you to
  the homepage instead of trying to trigger the query.

BUG=708844
==========

to

==========
🔍 Continue working on the search widget prototype

General cleanup:
* Further encapsulate the SearchActivityLocationBarLayout.

* Enable the search widget on Canary so that we can get
  _some_ testing.

Microphone fixes:
* Switch to singleTask so that the microphone works on JB
  and KK: Android changed semantics for
  startActivityForResult for singleInstance tasks somewhere
  after that.  We were already properly handling singleTask
  behavior because of the onNewIntent call anyway.

* Hook into Activity#onRequestPermissionsResult so that
  we can properly listen for permissions changes and trigger
  a voice query afterward.

* If we're not confident in the search query, the result is
  put into the text box.  Hitting enter previously sent you
  to the first link in the suggestions instead of properly
  regenerating them.  This was fixed by avoiding trying to
  refocus and reset the query when the microphone result
  came in.

Transition fixes:
* Stop calling finish() from onStop().  This messed up when
  the user went to recents and then re-entered the
  SearchActivity immediately.

* Clean up some more of the activity creation, including
  getting rid of an unnecessary style.  This fixes up
  some of the background color transitions slightly.

BUG=708844
==========

[gone, 2017-04-11 06:36:11]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 06:36:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 07:24:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 07:24:47]

Dry run: This issue passed the CQ dry run.

[Yusuf, 2017-04-11 17:45:21]

lgtm

[Ted C, 2017-04-11 17:57:01]

lgtm

https://codereview.chromium.org/2814593003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
(right):

https://codereview.chromium.org/2814593003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java:79:
// TODO(dfalcantara): This is from ChromeWindow, but there is no shared base
class.
s/ChromeWindow/ChromeActivity

What is the TODO here?  Is this more a comment than something actionable?

[gone, 2017-04-11 18:16:44]

Fixed the TODO.  Also adjusted one of the margins a bit, but I don't think you
need to re-review that.  We've got bigger styling problems to deal with later.

https://codereview.chromium.org/2814593003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
(right):

https://codereview.chromium.org/2814593003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java:79:
// TODO(dfalcantara): This is from ChromeWindow, but there is no shared base
class.
On 2017/04/11 17:57:01, Ted C wrote:
> s/ChromeWindow/ChromeActivity
> 
> What is the TODO here?  Is this more a comment than something actionable?

Er, the comment should be that they share a base class, but I don't want to rock
the boat for all AsyncInitializationActivities by adding that functionality in
this CL.  I'll adjust the comment.

[gone, 2017-04-11 18:17:58]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-04-11 18:17:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/2814593003/#ps80001
(title: "🔍 Continue cleaning up the search widget.")

[commit-bot: I haz the power, 2017-04-11 18:18:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 19:15:42]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491934678380420,
"parent_rev": "5d358265af599429828297cab308b27fc4f1e8aa", "commit_rev":
"24f29cd501c22986c8b80fbf4283c734be81c2b9"}

[commit-bot: I haz the power, 2017-04-11 19:16:31]

Description was changed from

==========
🔍 Continue working on the search widget prototype

General cleanup:
* Further encapsulate the SearchActivityLocationBarLayout.

* Enable the search widget on Canary so that we can get
  _some_ testing.

Microphone fixes:
* Switch to singleTask so that the microphone works on JB
  and KK: Android changed semantics for
  startActivityForResult for singleInstance tasks somewhere
  after that.  We were already properly handling singleTask
  behavior because of the onNewIntent call anyway.

* Hook into Activity#onRequestPermissionsResult so that
  we can properly listen for permissions changes and trigger
  a voice query afterward.

* If we're not confident in the search query, the result is
  put into the text box.  Hitting enter previously sent you
  to the first link in the suggestions instead of properly
  regenerating them.  This was fixed by avoiding trying to
  refocus and reset the query when the microphone result
  came in.

Transition fixes:
* Stop calling finish() from onStop().  This messed up when
  the user went to recents and then re-entered the
  SearchActivity immediately.

* Clean up some more of the activity creation, including
  getting rid of an unnecessary style.  This fixes up
  some of the background color transitions slightly.

BUG=708844
==========

to

==========
🔍 Continue working on the search widget prototype

General cleanup:
* Further encapsulate the SearchActivityLocationBarLayout.

* Enable the search widget on Canary so that we can get
  _some_ testing.

Microphone fixes:
* Switch to singleTask so that the microphone works on JB
  and KK: Android changed semantics for
  startActivityForResult for singleInstance tasks somewhere
  after that.  We were already properly handling singleTask
  behavior because of the onNewIntent call anyway.

* Hook into Activity#onRequestPermissionsResult so that
  we can properly listen for permissions changes and trigger
  a voice query afterward.

* If we're not confident in the search query, the result is
  put into the text box.  Hitting enter previously sent you
  to the first link in the suggestions instead of properly
  regenerating them.  This was fixed by avoiding trying to
  refocus and reset the query when the microphone result
  came in.

Transition fixes:
* Stop calling finish() from onStop().  This messed up when
  the user went to recents and then re-entered the
  SearchActivity immediately.

* Clean up some more of the activity creation, including
  getting rid of an unnecessary style.  This fixes up
  some of the background color transitions slightly.

BUG=708844

Review-Url: https://codereview.chromium.org/2814593003
Cr-Commit-Position: refs/heads/master@{#463715}
Committed:
https://chromium.googlesource.com/chromium/src/+/24f29cd501c22986c8b80fbf4283...
==========

[commit-bot: I haz the power, 2017-04-11 19:16:32]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/24f29cd501c22986c8b80fbf4283...