Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: gpu/command_buffer/common/discardable_handle.cc

Issue 2814583002: Service/ClientDiscardableManager (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/common/discardable_handle.cc
diff --git a/gpu/command_buffer/common/discardable_handle.cc b/gpu/command_buffer/common/discardable_handle.cc
index 987ad821f4508025b1e56665ca4ab7ed0671a82f..d7fa9cd642cd6cde1164ca724cb7e3358f8b2473 100644
--- a/gpu/command_buffer/common/discardable_handle.cc
+++ b/gpu/command_buffer/common/discardable_handle.cc
@@ -30,11 +30,11 @@ DiscardableHandleBase& DiscardableHandleBase::operator=(
DiscardableHandleBase& DiscardableHandleBase::operator=(
DiscardableHandleBase&& other) = default;
-bool DiscardableHandleBase::IsLockedForTesting() {
+bool DiscardableHandleBase::IsLockedForTesting() const {
return kHandleLockedStart <= base::subtle::NoBarrier_Load(AsAtomic());
}
-bool DiscardableHandleBase::IsDeletedForTesting() {
+bool DiscardableHandleBase::IsDeletedForTesting() const {
return kHandleDeleted == base::subtle::NoBarrier_Load(AsAtomic());
}
@@ -114,4 +114,11 @@ bool ServiceDiscardableHandle::Delete() {
AsAtomic(), kHandleUnlocked, kHandleDeleted);
}
+void ServiceDiscardableHandle::ForceDelete() {
+ // No barrier is needed as all GPU process access happens on a single thread,
+ // and communication of dependent data between the GPU process and the
+ // renderer process happens across the command buffer and includes barriers.
+ base::subtle::NoBarrier_Store(AsAtomic(), kHandleDeleted);
+}
+
} // namespace gpu
« no previous file with comments | « gpu/command_buffer/common/discardable_handle.h ('k') | gpu/command_buffer/common/gles2_cmd_format_autogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698