Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2814563004: [DevTools] Handle blocked urls disabled state better in UI (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Handle blocked urls disabled state better in UI Fixing checkbox resizing, making them disabled and a bit transparent when blocking overall is disabled, enabling blocking when adding a new pattern. BUG=709943 Review-Url: https://codereview.chromium.org/2814563004 Cr-Commit-Position: refs/heads/master@{#463408} Committed: https://chromium.googlesource.com/chromium/src/+/75f0c42bc1fa4789792e165292bef3334b97151e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js View 4 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/blockedURLsPane.css View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgozman
Take a look please.
3 years, 8 months ago (2017-04-10 19:39:15 UTC) #2
pfeldman
lgtm
3 years, 8 months ago (2017-04-10 21:07:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814563004/1
3 years, 8 months ago (2017-04-10 21:39:44 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 21:47:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75f0c42bc1fa4789792e165292be...

Powered by Google App Engine
This is Rietveld 408576698