Adding a new annotation to set ChildProcessAllocator settings in tests.

Adding a new annotation to set ChildProcessAllocator settings in tests.

Created a new annotation that lets tests specify settings for the
allocation of child services. It is mostly a clean-up to replace the
current use of the command line annotation with a more specific one.
As a result I had to create a new content specific instrumentation test
runner that registers that new content specific annotation.

BUG=702316
Review-Url: https://codereview.chromium.org/2814533002
Cr-Commit-Position: refs/heads/master@{#463440}
Committed: https://chromium.googlesource.com/chromium/src/+/857cc7b94a374decb02c7c98a3b84dd14ec6a275

[Jay Civelli, 2017-04-10 17:56:27]

Description was changed from

==========
Introducing a new annotation to change child process allocator.

BUG=
==========

to

==========
Adding a new annotation to set ChildProcessAllocator settings in tests.

Created a new annotation that lets test specify settings for the
allocation of child services. It is mostly a clean-up to replace the
current use of the command line allocation.
As a result I had to create a new content specific instrumentation test
runner that register that new content specific annotation.

BUG=702316
==========

[Jay Civelli, 2017-04-10 17:56:27]

jcivelli@chromium.org changed reviewers:
+ boliu@chromium.org

[Jay Civelli, 2017-04-10 17:56:48]

Patchset #1 (id:1) has been deleted

[Jay Civelli, 2017-04-10 17:56:54]

Patchset #1 (id:20001) has been deleted

[Jay Civelli, 2017-04-10 17:57:52]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 17:58:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jay Civelli, 2017-04-10 18:09:00]

Description was changed from

==========
Adding a new annotation to set ChildProcessAllocator settings in tests.

Created a new annotation that lets test specify settings for the
allocation of child services. It is mostly a clean-up to replace the
current use of the command line allocation.
As a result I had to create a new content specific instrumentation test
runner that register that new content specific annotation.

BUG=702316
==========

to

==========
Adding a new annotation to set ChildProcessAllocator settings in tests.

Created a new annotation that lets test specify settings for the
allocation of child services. It is mostly a clean-up to replace the
current use of the command line allocation.
As a result I had to create a new content specific instrumentation test
runner that registers that new content specific annotation.

BUG=702316
==========

[Jay Civelli, 2017-04-10 18:25:39]

Description was changed from

==========
Adding a new annotation to set ChildProcessAllocator settings in tests.

Created a new annotation that lets test specify settings for the
allocation of child services. It is mostly a clean-up to replace the
current use of the command line allocation.
As a result I had to create a new content specific instrumentation test
runner that registers that new content specific annotation.

BUG=702316
==========

to

==========
Adding a new annotation to set ChildProcessAllocator settings in tests.

Created a new annotation that lets test specify settings for the
allocation of child services. It is mostly a clean-up to replace the
current use of the command line annotation with a more specific one.
As a result I had to create a new content specific instrumentation test
runner that registers that new content specific annotation.

BUG=702316
==========

[Jay Civelli, 2017-04-10 18:28:11]

Description was changed from

==========
Adding a new annotation to set ChildProcessAllocator settings in tests.

Created a new annotation that lets test specify settings for the
allocation of child services. It is mostly a clean-up to replace the
current use of the command line annotation with a more specific one.
As a result I had to create a new content specific instrumentation test
runner that registers that new content specific annotation.

BUG=702316
==========

to

==========
Adding a new annotation to set ChildProcessAllocator settings in tests.

Created a new annotation that lets tests specify settings for the
allocation of child services. It is mostly a clean-up to replace the
current use of the command line annotation with a more specific one.
As a result I had to create a new content specific instrumentation test
runner that registers that new content specific annotation.

BUG=702316
==========

[boliu, 2017-04-10 18:43:42]

lgtm % junit3 question

https://codereview.chromium.org/2814533002/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
(right):

https://codereview.chromium.org/2814533002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java:510:
@ChildProcessAllocatorSettings(sandboxedServiceCount = 4)
does this work yet for junit3 tests?

https://codereview.chromium.org/2814533002/diff/40001/content/public/test/and...
File
content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettings.java
(right):

https://codereview.chromium.org/2814533002/diff/40001/content/public/test/and...
content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettings.java:13:

nit: remove empty line

[Jay Civelli, 2017-04-10 19:43:15]

https://codereview.chromium.org/2814533002/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
(right):

https://codereview.chromium.org/2814533002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java:510:
@ChildProcessAllocatorSettings(sandboxedServiceCount = 4)
On 2017/04/10 18:43:41, boliu wrote:
> does this work yet for junit3 tests?

I don't see why the version of junit should impact it. As long as we are running
the tests from our test runner, it should run the assertion hook which sets the
values accordingly (regardless of how the list of tests was retrieved).

https://codereview.chromium.org/2814533002/diff/40001/content/public/test/and...
File
content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettings.java
(right):

https://codereview.chromium.org/2814533002/diff/40001/content/public/test/and...
content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettings.java:13:

On 2017/04/10 18:43:41, boliu wrote:
> nit: remove empty line

Done.

[commit-bot: I haz the power, 2017-04-10 20:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 20:17:33]

Dry run: This issue passed the CQ dry run.

[Jay Civelli, 2017-04-10 21:04:19]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2017-04-10 21:04:20]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2814533002/#ps60001
(title: "Clean-up")

[commit-bot: I haz the power, 2017-04-10 21:05:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 21:21:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 21:21:36]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jay Civelli, 2017-04-10 21:25:06]

jcivelli@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Jay Civelli, 2017-04-10 21:25:06]

Adding dfalcantara@ for chrome/android/javatests and chrome/test/android OWNER
review.

[gone, 2017-04-10 23:05:16]

those two files lgtm

[Jay Civelli, 2017-04-10 23:05:51]

The CQ bit was checked by jcivelli@chromium.org

[commit-bot: I haz the power, 2017-04-10 23:06:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 23:17:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491865551633670,
"parent_rev": "633935afe86e414d2394d9e121ad53300b57913a", "commit_rev":
"857cc7b94a374decb02c7c98a3b84dd14ec6a275"}

[commit-bot: I haz the power, 2017-04-10 23:18:46]

Description was changed from

==========
Adding a new annotation to set ChildProcessAllocator settings in tests.

Created a new annotation that lets tests specify settings for the
allocation of child services. It is mostly a clean-up to replace the
current use of the command line annotation with a more specific one.
As a result I had to create a new content specific instrumentation test
runner that registers that new content specific annotation.

BUG=702316
==========

to

==========
Adding a new annotation to set ChildProcessAllocator settings in tests.

Created a new annotation that lets tests specify settings for the
allocation of child services. It is mostly a clean-up to replace the
current use of the command line annotation with a more specific one.
As a result I had to create a new content specific instrumentation test
runner that registers that new content specific annotation.

BUG=702316

Review-Url: https://codereview.chromium.org/2814533002
Cr-Commit-Position: refs/heads/master@{#463440}
Committed:
https://chromium.googlesource.com/chromium/src/+/857cc7b94a374decb02c7c98a3b8...
==========

[commit-bot: I haz the power, 2017-04-10 23:18:56]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/857cc7b94a374decb02c7c98a3b8...