MD Settings: Users: Focus dialog buttons on close

MD Settings: Users: Focus dialog buttons on close

BUG=709148
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2814423002
Cr-Commit-Position: refs/heads/master@{#464497}
Committed: https://chromium.googlesource.com/chromium/src/+/092d3492acf064752a5776b4fd07ac21d39d2a98

[stevenjb, 2017-04-13 17:38:54]

Description was changed from

==========
MD Settings: Users: Focus dialog buttons on close

BUG=709148
==========

to

==========
MD Settings: Users: Focus dialog buttons on close

BUG=709148
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-13 17:45:03]

stevenjb@chromium.org changed reviewers:
+ dpapad@chromium.org, sammiequon@chromium.org

[sammiequon, 2017-04-13 17:54:09]

lgtm, thanks!

[dpapad, 2017-04-13 17:56:32]

LGTM

https://codereview.chromium.org/2814423002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/fingerprint_list.html
(right):

https://codereview.chromium.org/2814423002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/fingerprint_list.html:68: <i
class="settings-box continuation">$i18n{lockScreenFingerprintWarning}</i>
Drive-by comment (ignore for this CL): <i> is a fairly old HTML element, and is
not necessary anymore. Instead CSS "font-style: italic;" is preferred (in the
spirit of "CSS should define style, HTML should define content").

https://codereview.chromium.org/2814423002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/fingerprint_list.html:72:
on-close="onAddFingerprintDialogClose_">
Nit (optional): Maybe rename to onSetupFingerprintDialogClose_ since the dialog
is named "setup-fingerprint-dialog".

https://codereview.chromium.org/2814423002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/lock_screen.js (right):

https://codereview.chromium.org/2814423002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/lock_screen.js:211:
this.$$('#unlockType').focus();
Nit (optional): The new ID seems redundant, since the element can already by
uniquely identified with $$('paper-radio-group').

https://codereview.chromium.org/2814423002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/lock_screen.js:221:
this.$$('#setupPinLink').focus();
Nit (optional): Same here, $$('link[is=action-link]') would also locate the same
element.

[stevenjb, 2017-04-13 18:02:10]

https://codereview.chromium.org/2814423002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/fingerprint_list.html
(right):

https://codereview.chromium.org/2814423002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/fingerprint_list.html:68: <i
class="settings-box continuation">$i18n{lockScreenFingerprintWarning}</i>
On 2017/04/13 17:56:32, dpapad wrote:
> Drive-by comment (ignore for this CL): <i> is a fairly old HTML element, and
is
> not necessary anymore. Instead CSS "font-style: italic;" is preferred (in the
> spirit of "CSS should define style, HTML should define content").

Acknowledged.

https://codereview.chromium.org/2814423002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/fingerprint_list.html:72:
on-close="onAddFingerprintDialogClose_">
On 2017/04/13 17:56:32, dpapad wrote:
> Nit (optional): Maybe rename to onSetupFingerprintDialogClose_ since the
dialog
> is named "setup-fingerprint-dialog".

Done.

https://codereview.chromium.org/2814423002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/lock_screen.js (right):

https://codereview.chromium.org/2814423002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/lock_screen.js:211:
this.$$('#unlockType').focus();
On 2017/04/13 17:56:32, dpapad wrote:
> Nit (optional): The new ID seems redundant, since the element can already by
> uniquely identified with $$('paper-radio-group').

For now... This page may grow over time. *shrug*

https://codereview.chromium.org/2814423002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/lock_screen.js:221:
this.$$('#setupPinLink').focus();
On 2017/04/13 17:56:32, dpapad wrote:
> Nit (optional): Same here, $$('link[is=action-link]') would also locate the
same
> element.

Ditto.

[stevenjb, 2017-04-13 18:02:13]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-04-13 18:02:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
sammiequon@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2814423002/#ps20001
(title: "Feedback")

[commit-bot: I haz the power, 2017-04-13 18:03:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 19:19:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492106533002310,
"parent_rev": "7da138164fb7dc30540f1340df0fd93b4d417a34", "commit_rev":
"092d3492acf064752a5776b4fd07ac21d39d2a98"}

[commit-bot: I haz the power, 2017-04-13 19:20:54]

Description was changed from

==========
MD Settings: Users: Focus dialog buttons on close

BUG=709148
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Users: Focus dialog buttons on close

BUG=709148
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2814423002
Cr-Commit-Position: refs/heads/master@{#464497}
Committed:
https://chromium.googlesource.com/chromium/src/+/092d3492acf064752a5776b4fd07...
==========

[commit-bot: I haz the power, 2017-04-13 19:20:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/092d3492acf064752a5776b4fd07...