Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2814383002: Revert of [web-page-replay] Roll WPR to the latest commit (Closed)

Created:
3 years, 8 months ago by nednguyen
Modified:
3 years, 8 months ago
Reviewers:
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [web-page-replay] Roll WPR to the latest commit (patchset #1 id:1 of https://codereview.chromium.org/2811373002/ ) Reason for revert: Suspect that this caused mass test failures on Chromium perf BUG=chromium:711232 Original issue's description: > [web-page-replay] Roll WPR to the latest commit > > List of changes: > git log 6cffdf1fb6c9a6d5dccbcc9cc18b8738a538eeba..538d30fa1b1ff1e549d9fbc09ed2f60e5f87861b --date=short --no-merges --format='%ad %ae %s' > 2017-04-12 rsleevi@chromium.org Always include a subjectAltName and extendedKeyUsage extension in certs > > > BUG=chromium:702194 > TBR=rsleevi@chromium.org > > Review-Url: https://codereview.chromium.org/2811373002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/41bda73617edc29dbca3eda9b97a7b33f665c393 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:702194 Review-Url: https://codereview.chromium.org/2814383002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4709b3a00e515aaac4e58b904dfbf1622c7a340a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M telemetry/third_party/web-page-replay/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/third_party/web-page-replay/certutils.py View 3 chunks +10 lines, -4 lines 0 comments Download
M telemetry/third_party/web-page-replay/certutils_test.py View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nednguyen
Created Revert of [web-page-replay] Roll WPR to the latest commit
3 years, 8 months ago (2017-04-13 13:44:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814383002/1
3 years, 8 months ago (2017-04-13 13:44:28 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 13:44:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698