Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2814313003: Reland: Build ZIP archiver. (Closed)

Created:
3 years, 8 months ago by takise
Modified:
3 years, 8 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, fukino+watch_chromium.org, yawano
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Build ZIP archiver. This CL adds and changes some files in ui/file_manager to build ZIP archiver. We are going to add ZIP archiver to the list of component extensions in another CL, so ZIP archiver still won't show up in the context menu with this patch. BUG=607078 TEST=manually tested CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2808993003 Cr-Commit-Position: refs/heads/master@{#464309} Committed: https://chromium.googlesource.com/chromium/src/+/77065d9816b34a5cc7913894b8b756e7c3e6fb79 patch from issue 2808993003 at patchset 80001 (http://crrev.com/2808993003#ps80001) Review-Url: https://codereview.chromium.org/2814313003 Cr-Commit-Position: refs/heads/master@{#464340} Committed: https://chromium.googlesource.com/chromium/src/+/a1644c12446b4d6638ea52d567bc92eef927d61b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -9 lines) Patch
M ui/file_manager/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +30 lines, -0 lines 0 comments Download
A ui/file_manager/zip_archiver/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A ui/file_manager/zip_archiver/cpp/BUILD.gn View 1 chunk +38 lines, -0 lines 0 comments Download
M ui/file_manager/zip_archiver/manifest.json View 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
takise
PTAL. Thank you!
3 years, 8 months ago (2017-04-13 07:00:49 UTC) #3
mtomasz
lgtm
3 years, 8 months ago (2017-04-13 07:03:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814313003/1
3 years, 8 months ago (2017-04-13 08:24:59 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 08:31:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a1644c12446b4d6638ea52d567bc...

Powered by Google App Engine
This is Rietveld 408576698