Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2814303003: Disable invalid assertion in GetSystemMemoryInfo test on iOS. (Closed)

Created:
3 years, 8 months ago by liaoyuke
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable invalid assertion in GetSystemMemoryInfo test on iOS. SystemMetrics2Test.GetSystemMemoryInfo is flaky on iOS devices and fails on the following line: EXPECT_LT(info.free, info.total). The test fails about 30 runs during the past 100 builds. This CL disables the invalid assertion. BUG=711450 Review-Url: https://codereview.chromium.org/2814303003 Cr-Commit-Position: refs/heads/master@{#464583} Committed: https://chromium.googlesource.com/chromium/src/+/71606ecc2ff8f79fd8aa0b9d6f41c8f747a6d470

Patch Set 1 : tmp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/process/process_metrics_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
liaoyuke
Hi Nico, PTAL. Thank you very much!
3 years, 8 months ago (2017-04-13 21:51:12 UTC) #4
Nico
lgtm
3 years, 8 months ago (2017-04-13 21:55:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814303003/20001
3 years, 8 months ago (2017-04-13 22:04:01 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 22:47:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/71606ecc2ff8f79fd8aa0b9d6f41...

Powered by Google App Engine
This is Rietveld 408576698