cc: Make DamageTracker use the effect tree and layer list

cc: Make DamageTracker use the effect tree and layer list

This makes DamageTracker use the effect tree and layer list rather than
traversing the render surface layer list.

The ordering requirements that we need to maintain are:
1) Each render surface's damage must be computed before its target's
   damage can be computed.
2) When accumulating the damage for a render surface, contributing
   layers and surfaces must be visited in draw order, since a
   contributing surface with a background filter expands damage from
   contributors behind it (before it in draw order) but not from
   contributors after it.

We do this by visiting the top-level layer list in draw order, adding
the damage for each layer to its target's accumulated damage. Whenever
all of a surface's contributors have been visited (this can be determined
using the effect tree and each layer's effect tree index), the surface's
damage is computed and then added to its own target's accumulated damage.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2814273003
Cr-Commit-Position: refs/heads/master@{#465339}
Committed: https://chromium.googlesource.com/chromium/src/+/9c92fa02ca4c58cf5338ac0c7d59cdd3cf22ed13

[ajuma, 2017-04-13 18:45:03]

Description was changed from

==========
cc: Make DamageTracker use the effect tree and layer list

This makes DamageTracker use the effect tree and layer list rather than
traversing the render surface layer list.

The ordering requirements that we need to maintain are:
1) Each render surface's damage must be computed before its target's
   damage can be computed.
2) When accumulating the damage for a render surface, contributing
   layers and surfaces must be visited in draw order, since a
   contributing surface with a background filter expands damage from
   contributors behind it (before it in draw order) but not from
   contributors after it.

We do this by visiting the top-level layer list in draw order, adding
the damage for each layer to its target's accumulated damage. Whenever
all of a surface's contributors have been visited (this can be determined
using the effect tree and each layer's effect tree index), the surface's
damage is computed and then added to its own target's accumulated damage.

BUG=611883
==========

to

==========
cc: Make DamageTracker use the effect tree and layer list

This makes DamageTracker use the effect tree and layer list rather than
traversing the render surface layer list.

The ordering requirements that we need to maintain are:
1) Each render surface's damage must be computed before its target's
   damage can be computed.
2) When accumulating the damage for a render surface, contributing
   layers and surfaces must be visited in draw order, since a
   contributing surface with a background filter expands damage from
   contributors behind it (before it in draw order) but not from
   contributors after it.

We do this by visiting the top-level layer list in draw order, adding
the damage for each layer to its target's accumulated damage. Whenever
all of a surface's contributors have been visited (this can be determined
using the effect tree and each layer's effect tree index), the surface's
damage is computed and then added to its own target's accumulated damage.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ajuma, 2017-04-13 21:09:43]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 21:10:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2017-04-13 21:28:16]

Description was changed from

==========
cc: Make DamageTracker use the effect tree and layer list

This makes DamageTracker use the effect tree and layer list rather than
traversing the render surface layer list.

The ordering requirements that we need to maintain are:
1) Each render surface's damage must be computed before its target's
   damage can be computed.
2) When accumulating the damage for a render surface, contributing
   layers and surfaces must be visited in draw order, since a
   contributing surface with a background filter expands damage from
   contributors behind it (before it in draw order) but not from
   contributors after it.

We do this by visiting the top-level layer list in draw order, adding
the damage for each layer to its target's accumulated damage. Whenever
all of a surface's contributors have been visited (this can be determined
using the effect tree and each layer's effect tree index), the surface's
damage is computed and then added to its own target's accumulated damage.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Make DamageTracker use the effect tree and layer list

This makes DamageTracker use the effect tree and layer list rather than
traversing the render surface layer list.

The ordering requirements that we need to maintain are:
1) Each render surface's damage must be computed before its target's
   damage can be computed.
2) When accumulating the damage for a render surface, contributing
   layers and surfaces must be visited in draw order, since a
   contributing surface with a background filter expands damage from
   contributors behind it (before it in draw order) but not from
   contributors after it.

We do this by visiting the top-level layer list in draw order, adding
the damage for each layer to its target's accumulated damage. Whenever
all of a surface's contributors have been visited (this can be determined
using the effect tree and each layer's effect tree index), the surface's
damage is computed and then added to its own target's accumulated damage.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ajuma, 2017-04-13 21:28:17]

ajuma@chromium.org changed reviewers:
+ jaydasika@chromium.org, weiliangc@chromium.org

[commit-bot: I haz the power, 2017-04-13 22:13:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 22:13:03]

Dry run: This issue passed the CQ dry run.

[jaydasika, 2017-04-14 23:19:51]

lgtm

[ajuma, 2017-04-18 14:40:12]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 14:40:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 15:49:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 15:49:48]

Dry run: This issue passed the CQ dry run.

[ajuma, 2017-04-18 19:47:44]

The CQ bit was checked by ajuma@chromium.org

[ajuma, 2017-04-18 19:47:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
jaydasika@chromium.org
Link to the patchset: https://codereview.chromium.org/2814273003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-18 19:48:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 19:53:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492544864288980,
"parent_rev": "a4f4b8b4b11d8ed73d25d9309831e3ff14f287a1", "commit_rev":
"9c92fa02ca4c58cf5338ac0c7d59cdd3cf22ed13"}

[commit-bot: I haz the power, 2017-04-18 19:53:24]

Description was changed from

==========
cc: Make DamageTracker use the effect tree and layer list

This makes DamageTracker use the effect tree and layer list rather than
traversing the render surface layer list.

The ordering requirements that we need to maintain are:
1) Each render surface's damage must be computed before its target's
   damage can be computed.
2) When accumulating the damage for a render surface, contributing
   layers and surfaces must be visited in draw order, since a
   contributing surface with a background filter expands damage from
   contributors behind it (before it in draw order) but not from
   contributors after it.

We do this by visiting the top-level layer list in draw order, adding
the damage for each layer to its target's accumulated damage. Whenever
all of a surface's contributors have been visited (this can be determined
using the effect tree and each layer's effect tree index), the surface's
damage is computed and then added to its own target's accumulated damage.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Make DamageTracker use the effect tree and layer list

This makes DamageTracker use the effect tree and layer list rather than
traversing the render surface layer list.

The ordering requirements that we need to maintain are:
1) Each render surface's damage must be computed before its target's
   damage can be computed.
2) When accumulating the damage for a render surface, contributing
   layers and surfaces must be visited in draw order, since a
   contributing surface with a background filter expands damage from
   contributors behind it (before it in draw order) but not from
   contributors after it.

We do this by visiting the top-level layer list in draw order, adding
the damage for each layer to its target's accumulated damage. Whenever
all of a surface's contributors have been visited (this can be determined
using the effect tree and each layer's effect tree index), the surface's
damage is computed and then added to its own target's accumulated damage.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2814273003
Cr-Commit-Position: refs/heads/master@{#465339}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c92fa02ca4c58cf5338ac0c7d59...
==========

[commit-bot: I haz the power, 2017-04-18 19:53:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9c92fa02ca4c58cf5338ac0c7d59...