DevTools: Show a list of availble QuickOpen providers

DevTools: Show a list of availble QuickOpen providers

This adds a new QuickOpenProvider '?' that can be be used to jump to
another provider or search for help.

BUG=662081
Review-Url: https://codereview.chromium.org/2814263002
Cr-Commit-Position: refs/heads/master@{#464330}
Committed: https://chromium.googlesource.com/chromium/src/+/20494ca2b4c2a39d4779ce374271a0871e9e414d

[einbinder, 2017-04-12 21:37:50]

einbinder@chromium.org changed reviewers:
+ pfeldman@chromium.org

[einbinder, 2017-04-12 21:37:50]

ptal

https://codereview.chromium.org/2814263002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/quick_open/HelpQuickOpen.js
(right):

https://codereview.chromium.org/2814263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/quick_open/HelpQuickOpen.js:68:
InspectorFrontendHost.openInNewTab(
I'm not sure how I feel about this, but it was easy so I added it.

[pfeldman, 2017-04-13 00:30:52]

lgtm

https://codereview.chromium.org/2814263002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
(left):

https://codereview.chromium.org/2814263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js:29:
this._prompt.renderAsBlock();
Wasn't it breaking something?

https://codereview.chromium.org/2814263002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/quick_open/HelpQuickOpen.js
(right):

https://codereview.chromium.org/2814263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/quick_open/HelpQuickOpen.js:68:
InspectorFrontendHost.openInNewTab(
Don't do that, just the line 72?

[einbinder, 2017-04-13 01:22:23]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2017-04-13 01:22:24]

https://codereview.chromium.org/2814263002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
(left):

https://codereview.chromium.org/2814263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js:29:
this._prompt.renderAsBlock();
On 2017/04/13 at 00:30:51, pfeldman wrote:
> Wasn't it breaking something?

Not since crrev.com/462601 which removed the linebreak in empty prompts. I
haven't found anything that breaks.

https://codereview.chromium.org/2814263002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/quick_open/HelpQuickOpen.js
(right):

https://codereview.chromium.org/2814263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/quick_open/HelpQuickOpen.js:68:
InspectorFrontendHost.openInNewTab(
On 2017/04/13 at 00:30:51, pfeldman wrote:
> Don't do that, just the line 72?

Done.

[einbinder, 2017-04-13 01:22:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2814263002/#ps20001
(title: "Changes")

[commit-bot: I haz the power, 2017-04-13 01:23:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 02:53:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 02:53:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[einbinder, 2017-04-13 03:34:05]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-04-13 03:34:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 05:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 05:13:01]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[einbinder, 2017-04-13 06:53:19]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-04-13 06:53:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 07:29:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492066399946440,
"parent_rev": "cb6838f5badc8c2df03f387f4aa726629214179a", "commit_rev":
"20494ca2b4c2a39d4779ce374271a0871e9e414d"}

[commit-bot: I haz the power, 2017-04-13 07:30:14]

Description was changed from

==========
DevTools: Show a list of availble QuickOpen providers

This adds a new QuickOpenProvider '?' that can be be used to jump to
another provider or search for help.

BUG=662081
==========

to

==========
DevTools: Show a list of availble QuickOpen providers

This adds a new QuickOpenProvider '?' that can be be used to jump to
another provider or search for help.

BUG=662081

Review-Url: https://codereview.chromium.org/2814263002
Cr-Commit-Position: refs/heads/master@{#464330}
Committed:
https://chromium.googlesource.com/chromium/src/+/20494ca2b4c2a39d4779ce374271...
==========

[commit-bot: I haz the power, 2017-04-13 07:30:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/20494ca2b4c2a39d4779ce374271...