Move feature policy vibrate tests to correct directory

Move feature policy vibrate tests to correct directory

vibrate is not behind the flag FeaturePolicyExpeirmentalFeatures, so
move the virtual tests to feature-policy-experiment-features/ from
feature-policy/

BUG=710850
Review-Url: https://codereview.chromium.org/2814153002
Cr-Commit-Position: refs/heads/master@{#466634}
Committed: https://chromium.googlesource.com/chromium/src/+/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2

[lunalu1, 2017-04-12 17:30:45]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[lunalu1, 2017-04-12 17:31:36]

lunalu@chromium.org changed reviewers:
+ iclelland@chromium.org

[lunalu1, 2017-04-12 17:31:37]

Hi Ian, could you please take a look at this CL?
I forgot to move the virtual tests to the right dir now all fp vibrate tests are
failing :(

[commit-bot: I haz the power, 2017-04-12 17:31:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2017-04-12 17:34:02]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 17:34:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iclelland, 2017-04-12 18:04:48]

On 2017/04/12 17:31:37, loonybear wrote:
> Hi Ian, could you please take a look at this CL?
> I forgot to move the virtual tests to the right dir now all fp vibrate tests
are
> failing :(

It looks like feature-policy-experimental-features is a new virtual test suite
that you're adding with this CL - if that's right, you'll need to add it to
third_party/WebKit/LayoutTests/VirtualTestSuites as well.

Also, did you mean to delete
third_party/WebKit/LayoutTests/http/tests/feature-policy/vibrate-enabledforself-expected.txt,
and not move it with the other files?

[commit-bot: I haz the power, 2017-04-12 18:57:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 18:57:33]

Dry run: This issue passed the CQ dry run.

[lunalu1, 2017-04-12 19:48:23]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 19:49:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 20:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 20:52:19]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lunalu1, 2017-04-12 21:34:42]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 21:36:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2017-04-12 21:51:47]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 21:52:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 22:02:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 22:02:11]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lunalu1, 2017-04-13 14:38:20]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 14:38:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 14:45:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 14:45:04]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lunalu1, 2017-04-13 18:26:36]

Patchset #6 (id:90001) has been deleted

[lunalu1, 2017-04-13 18:27:44]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[lunalu1, 2017-04-13 18:28:07]

Patchset #5 (id:70001) has been deleted

[lunalu1, 2017-04-13 18:28:13]

Patchset #4 (id:40002) has been deleted

[commit-bot: I haz the power, 2017-04-13 18:28:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2017-04-13 18:28:34]

Please take another look. Thanks

[lunalu1, 2017-04-13 18:38:05]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-04-13 18:42:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 18:42:46]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[iclelland, 2017-04-13 19:31:10]

On 2017/04/13 18:28:34, loonybear wrote:
> Please take another look. Thanks

This looks good, but there are still some failures -- if you are going to add
the change in
	third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp to this CL,
you'll need to update the tests in FeaturePolicyTest.cpp as well.

You can move that change to a new CL if you want to land this one separately, or
else please update those unit tests, and also mention it in the description (and
add bug #710850 to the BUG= line as well)

[lunalu1, 2017-04-13 20:21:43]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 20:22:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 20:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 20:35:49]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lunalu1, 2017-04-18 21:09:49]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 21:10:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 21:14:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 21:14:34]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lunalu1, 2017-04-18 21:23:49]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 21:24:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 21:34:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 21:34:59]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lunalu1, 2017-04-19 14:32:01]

Hi Ian, could you PTAL

[iclelland, 2017-04-19 17:23:28]

Thanks for doing this, Luna -- adding the map makes testing look cleaner. This
LGTM, with just a couple of comments.

https://codereview.chromium.org/2814153002/diff/130001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
(right):

https://codereview.chromium.org/2814153002/diff/130001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp:52: return
WebFeaturePolicyFeature::kNotFound;
Can you check to see if kNotFound is used anywhere else in the codebase? I
suspect we can get rid of it, that it was only used here.

https://codereview.chromium.org/2814153002/diff/170001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h (right):

https://codereview.chromium.org/2814153002/diff/170001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h:35:
PLATFORM_EXPORT WebParsedFeaturePolicy
Can you add a comment here that this version with the explicit map is used
internally and for tests?

https://codereview.chromium.org/2814153002/diff/170001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp
(right):

https://codereview.chromium.org/2814153002/diff/170001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp:50:
const FeatureNameMap dummy_feature_name_map = {
Maybe rename this to something like test_feature_name_map?

[lunalu1, 2017-04-19 20:33:18]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 20:34:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2017-04-19 20:34:34]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 20:35:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2017-04-19 20:37:12]

lunalu@chromium.org changed reviewers:
+ jochen@chromium.org

[lunalu1, 2017-04-19 20:37:13]

Hi jochen,

Could you please take a look at:
content/browser/site_per_process_browsertest.cc
  third_party/WebKit/Source/core/html/HTMLIFrameElementAllow.cpp
  third_party/WebKit/Source/platform/feature_policy/FeaturePolicy[.cpp | .h |
Test.cpp]

Thanks

[commit-bot: I haz the power, 2017-04-19 20:42:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 20:42:49]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jochen (gone - plz use gerrit), 2017-04-20 09:49:22]

lgtm

[lunalu1, 2017-04-20 19:24:48]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 19:25:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 19:36:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 19:36:40]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lunalu1, 2017-04-20 19:49:59]

Patchset #8 (id:210001) has been deleted

[lunalu1, 2017-04-20 19:50:21]

The CQ bit was checked by lunalu@chromium.org

[lunalu1, 2017-04-20 19:50:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
iclelland@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2814153002/#ps230001
(title: "Enable fp vibrate test behind experimental flag")

[commit-bot: I haz the power, 2017-04-20 19:51:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 21:00:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 21:00:16]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lunalu1, 2017-04-21 14:54:37]

The CQ bit was checked by lunalu@chromium.org

[lunalu1, 2017-04-21 14:54:38]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
iclelland@chromium.org
Link to the patchset: https://codereview.chromium.org/2814153002/#ps250001
(title: "Update test expect")

[commit-bot: I haz the power, 2017-04-21 14:54:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 14:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 14:58:02]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lunalu1, 2017-04-21 20:37:44]

The CQ bit was checked by lunalu@chromium.org

[lunalu1, 2017-04-21 20:37:44]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
iclelland@chromium.org
Link to the patchset: https://codereview.chromium.org/2814153002/#ps270001
(title: "Rebase update")

[commit-bot: I haz the power, 2017-04-21 20:38:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2017-04-21 22:13:32]

The CQ bit was checked by lunalu@chromium.org

[lunalu1, 2017-04-21 22:13:32]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
iclelland@chromium.org
Link to the patchset: https://codereview.chromium.org/2814153002/#ps290001
(title: "Updated virtual test expect for vibrate")

[commit-bot: I haz the power, 2017-04-21 22:13:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 23:20:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 23:20:23]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lunalu1, 2017-04-24 14:20:50]

Patchset #10 (id:270001) has been deleted

[lunalu1, 2017-04-24 14:21:00]

The CQ bit was checked by lunalu@chromium.org

[lunalu1, 2017-04-24 14:21:00]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
iclelland@chromium.org
Link to the patchset: https://codereview.chromium.org/2814153002/#ps310001
(title: "Update test expect")

[lunalu1, 2017-04-24 14:21:07]

Patchset #10 (id:290001) has been deleted

[lunalu1, 2017-04-24 14:21:14]

Patchset #9 (id:250001) has been deleted

[commit-bot: I haz the power, 2017-04-24 14:21:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lunalu1, 2017-04-24 14:21:41]

The CQ bit was checked by lunalu@chromium.org

[commit-bot: I haz the power, 2017-04-24 14:22:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 15:53:29]

CQ is committing da patch.

Bot data: {"patchset_id": 310001, "attempt_start_ts": 1493043701213920,
"parent_rev": "91522d0519823a43060738914a65b71119b669d7", "commit_rev":
"db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2"}

[commit-bot: I haz the power, 2017-04-24 15:53:42]

Description was changed from

==========
Move feature policy vibrate tests to correct directory

vibrate is not behind the flag FeaturePolicyExpeirmentalFeatures, so
move the virtual tests to feature-policy-experiment-features/ from
feature-policy/

BUG=710850
==========

to

==========
Move feature policy vibrate tests to correct directory

vibrate is not behind the flag FeaturePolicyExpeirmentalFeatures, so
move the virtual tests to feature-policy-experiment-features/ from
feature-policy/

BUG=710850

Review-Url: https://codereview.chromium.org/2814153002
Cr-Commit-Position: refs/heads/master@{#466634}
Committed:
https://chromium.googlesource.com/chromium/src/+/db0b96ce2d50d57a55f6f5c44aeb...
==========

[commit-bot: I haz the power, 2017-04-24 15:53:44]

Committed patchset #9 (id:310001) as
https://chromium.googlesource.com/chromium/src/+/db0b96ce2d50d57a55f6f5c44aeb...