Issue 2814143002: Various fixes for sync socket implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2814143002: Various fixes for sync socket implementation. (Closed)

Created:
3 years, 8 months ago by bkonyi

Modified:
3 years, 8 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Various fixes for sync socket implementation. Revert "Revert "Added sync_socket.h include in sync_socket_win.cc"" This reverts commit 2bd6168e1ebf35f6dbd9b2724339362c493377fc. Revert "Revert "Added synchronous socket implementation to dart:io."" This reverts commit a47bce03f5502dac7fb12e777e87b5aa1cfc830b. BUG=

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1800 lines, -45 lines)			Patch
M	pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/bin/io_impl_sources.gypi	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/bin/io_natives.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
	runtime/bin/io_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/socket_android.cc	View	1 chunk	+2 lines, -9 lines	0 comments	Download
M	runtime/bin/socket_fuchsia.cc	View	1 chunk	+2 lines, -13 lines	0 comments	Download
M	runtime/bin/socket_linux.cc	View	1 chunk	+2 lines, -12 lines	0 comments	Download
M	runtime/bin/socket_macos.cc	View	1 chunk	+2 lines, -11 lines	0 comments	Download
M	runtime/bin/socket_unsupported.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	runtime/bin/sync_socket.h	View	1 chunk	+48 lines, -0 lines	0 comments	Download
A	runtime/bin/sync_socket.cc	View	1 chunk	+365 lines, -0 lines	0 comments	Download
A	runtime/bin/sync_socket_android.cc	View	1 chunk	+80 lines, -0 lines	0 comments	Download
A	runtime/bin/sync_socket_fuchsia.cc	View	1 chunk	+80 lines, -0 lines	0 comments	Download
A	runtime/bin/sync_socket_linux.cc	View	1 chunk	+80 lines, -0 lines	0 comments	Download
A	runtime/bin/sync_socket_macos.cc	View	1 chunk	+77 lines, -0 lines	0 comments	Download
A	runtime/bin/sync_socket_patch.dart	View	1 chunk	+347 lines, -0 lines	0 comments	Download
A	runtime/bin/sync_socket_win.cc	View	1 chunk	+78 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/io_patch.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download
	sdk/lib/io/io.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/io/io_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	sdk/lib/io/sync_socket.dart	View	1 chunk	+108 lines, -0 lines	0 comments	Download
A	tests/standalone/io/raw_synchronous_socket_test.dart	View	1 chunk	+490 lines, -0 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2812153002 Patch 1