Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2812153002: Revert "Added synchronous socket implementation to dart:io." (Closed)

Created:
3 years, 8 months ago by bkonyi
Modified:
3 years, 8 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Added synchronous socket implementation to dart:io." This reverts commit a1f87ebdb835efdc91db5f18f81603658f1f7e32. Revert "Added sync_socket.h include in sync_socket_win.cc" This reverts commit bdec13e865d916e1ec3be1c23eb8b549d89ebd87. BUG= Committed: https://github.com/dart-lang/sdk/commit/b439bd9a5480014313a4694d49c6ba3efbdaa926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1771 lines) Patch
M pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/bin/io_impl_sources.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/bin/io_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/socket_android.cc View 1 chunk +10 lines, -1 line 0 comments Download
M runtime/bin/socket_fuchsia.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M runtime/bin/socket_unsupported.cc View 1 chunk +0 lines, -1 line 0 comments Download
D runtime/bin/sync_socket.h View 1 chunk +0 lines, -48 lines 0 comments Download
D runtime/bin/sync_socket.cc View 1 chunk +0 lines, -365 lines 0 comments Download
D runtime/bin/sync_socket_android.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D runtime/bin/sync_socket_fuchsia.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D runtime/bin/sync_socket_linux.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D runtime/bin/sync_socket_macos.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D runtime/bin/sync_socket_patch.dart View 1 chunk +0 lines, -347 lines 0 comments Download
D runtime/bin/sync_socket_win.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/io_patch.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M sdk/lib/io/io.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/io/io_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D sdk/lib/io/sync_socket.dart View 1 chunk +0 lines, -108 lines 0 comments Download
D tests/standalone/io/raw_synchronous_socket_test.dart View 1 chunk +0 lines, -490 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
bkonyi
Reverting for now...
3 years, 8 months ago (2017-04-11 22:18:35 UTC) #2
bkonyi
Reverting for now...
3 years, 8 months ago (2017-04-11 22:18:37 UTC) #3
bkonyi
Committed patchset #1 (id:1) manually as b439bd9a5480014313a4694d49c6ba3efbdaa926 (presubmit successful).
3 years, 8 months ago (2017-04-11 22:18:56 UTC) #5
zra
3 years, 8 months ago (2017-04-11 22:20:03 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698