Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2814103003: Remove Speedometer from the PGO training set. (Closed)

Created:
3 years, 8 months ago by Sébastien Marchand
Modified:
3 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Speedometer from the PGO training set. This benchmark has been failing (timing out) for months now, so removing it won't affect the performance. The issue seem to be that Speedometer takes a while to tun, and it's much slower in a PGI build, so we timeout after 10 minutes and at this point the benchmark is still running. We could increase the timeout but as mentioned above this has been failing for months and we haven't noticed a performance regression. BUG=650432 Review-Url: https://codereview.chromium.org/2814103003 Cr-Commit-Position: refs/heads/master@{#465682} Committed: https://chromium.googlesource.com/chromium/src/+/aa335b32311ded1c056247d4a8baca404de732c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/win/run_pgo_profiling_benchmarks.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Sébastien Marchand
PTAL
3 years, 8 months ago (2017-04-19 18:34:19 UTC) #3
scottmg
lgtm
3 years, 8 months ago (2017-04-19 18:37:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814103003/1
3 years, 8 months ago (2017-04-19 18:44:08 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 18:56:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aa335b32311ded1c056247d4a8ba...

Powered by Google App Engine
This is Rietveld 408576698