Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2814073003: 📰 Fix SuggestionsBottomSheetTest#testContextMenu (Closed)

Created:
3 years, 8 months ago by dgn
Modified:
3 years, 8 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Fix SuggestionsBottomSheetTest#testContextMenu The touch disabled view is the bottom sheet itself rather than the recycler view after https://codereview.chromium.org/2810713002 landed, so the test should have been updated. BUG=710912 Review-Url: https://codereview.chromium.org/2814073003 Cr-Commit-Position: refs/heads/master@{#464110} Committed: https://chromium.googlesource.com/chromium/src/+/3bda5d3a105bda1fe84dccf5d0bccb1f5e33b077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dgn
PTAL
3 years, 8 months ago (2017-04-12 17:48:43 UTC) #4
Donn Denman
lgtm
3 years, 8 months ago (2017-04-12 17:49:59 UTC) #5
Donn Denman
Thanks Nicolas!
3 years, 8 months ago (2017-04-12 17:50:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814073003/1
3 years, 8 months ago (2017-04-12 18:48:04 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 19:36:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3bda5d3a105bda1fe84dccf5d0bc...

Powered by Google App Engine
This is Rietveld 408576698