Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2814043002: [headless] Add command line flag for default background color. (Closed)

Created:
3 years, 8 months ago by Eric Seckler
Modified:
3 years, 8 months ago
CC:
chromium-reviews, Sami
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Add command line flag for default background color. Can be set to 0 to render with transparent background. BUG=689349 Review-Url: https://codereview.chromium.org/2814043002 Cr-Commit-Position: refs/heads/master@{#463974} Committed: https://chromium.googlesource.com/chromium/src/+/2c66e2634d348919f2f25954448ce162210140ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -11 lines) Patch
M headless/app/headless_shell.cc View 5 chunks +34 lines, -7 lines 0 comments Download
M headless/app/headless_shell_switches.h View 2 chunks +3 lines, -1 line 0 comments Download
M headless/app/headless_shell_switches.cc View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eric Seckler
3 years, 8 months ago (2017-04-12 08:49:21 UTC) #5
alex clarke (OOO till 29th)
lgtm
3 years, 8 months ago (2017-04-12 08:51:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814043002/1
3 years, 8 months ago (2017-04-12 08:52:20 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 09:18:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2c66e2634d348919f2f25954448c...

Powered by Google App Engine
This is Rietveld 408576698