[MD Bookmarks] Right click on bookmark items open context menu.

[MD Bookmarks] Right click on bookmark items open context menu.

This CL makes the context menu for bookmark items appear when an item is
clicked.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2814023004
Cr-Commit-Position: refs/heads/master@{#469281}
Committed: https://chromium.googlesource.com/chromium/src/+/a32022824f01698ab161130a96c2832a8226bb46

[calamity, 2017-04-12 09:21:03]

Description was changed from

==========
[MD Bookmarks] Right click on bookmark items open context menu.

This CL makes the context menu for bookmark items appear when an item is
clicked.

BUG=692837
==========

to

==========
[MD Bookmarks] Right click on bookmark items open context menu.

This CL makes the context menu for bookmark items appear when an item is
clicked.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2017-04-12 09:47:09]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2017-04-13 01:15:47]

Neat!

https://codereview.chromium.org/2814023004/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/item.js (right):

https://codereview.chromium.org/2814023004/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/item.js:66: e.preventDefault();
Minor suggestion: you should select the item here as well. It looks weird to
have one item selected, but then a different item with a context menu.

https://codereview.chromium.org/2814023004/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/list.js (right):

https://codereview.chromium.org/2814023004/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/list.js:94: * @param {Event} e
I think you should add a small comment here to show why this is needed

[calamity, 2017-04-13 04:56:04]

Patchset #2 (id:20001) has been deleted

[calamity, 2017-04-13 04:56:26]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 04:56:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-04-13 04:56:46]

https://codereview.chromium.org/2814023004/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/item.js (right):

https://codereview.chromium.org/2814023004/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/item.js:66: e.preventDefault();
On 2017/04/13 01:15:47, tsergeant wrote:
> Minor suggestion: you should select the item here as well. It looks weird to
> have one item selected, but then a different item with a context menu.

Done. This only happens if it's not selected since grouped selections should
stay where they are.

https://codereview.chromium.org/2814023004/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/list.js (right):

https://codereview.chromium.org/2814023004/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/list.js:94: * @param {Event} e
On 2017/04/13 01:15:47, tsergeant wrote:
> I think you should add a small comment here to show why this is needed

Done.

[tsergeant, 2017-04-13 05:48:25]

lgtm

https://codereview.chromium.org/2814023004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/list.js (right):

https://codereview.chromium.org/2814023004/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/list.js:108: this.$.dropdown.close();
nit: call this.closeDropdownMenu_()

[commit-bot: I haz the power, 2017-04-13 06:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 06:22:23]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-04-19 04:52:38]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 04:52:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-04-19 05:36:34]

https://codereview.chromium.org/2814023004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/list.js (right):

https://codereview.chromium.org/2814023004/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/list.js:108: this.$.dropdown.close();
On 2017/04/13 05:48:25, tsergeant wrote:
> nit: call this.closeDropdownMenu_()

Done.

[commit-bot: I haz the power, 2017-04-19 06:24:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 06:24:14]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-05-04 03:22:07]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 03:22:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 04:59:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 04:59:08]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-05-04 05:55:01]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-05-04 05:55:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2814023004/#ps80001
(title: "fix_nit")

[commit-bot: I haz the power, 2017-05-04 05:55:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 06:00:05]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493877301591380,
"parent_rev": "457a0ccf74d873f62036e0733a9e6fc5e005e03d", "commit_rev":
"a32022824f01698ab161130a96c2832a8226bb46"}

[commit-bot: I haz the power, 2017-05-04 06:00:50]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493877301591380,
"parent_rev": "457a0ccf74d873f62036e0733a9e6fc5e005e03d", "commit_rev":
"a32022824f01698ab161130a96c2832a8226bb46"}

[commit-bot: I haz the power, 2017-05-04 06:01:01]

Description was changed from

==========
[MD Bookmarks] Right click on bookmark items open context menu.

This CL makes the context menu for bookmark items appear when an item is
clicked.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Right click on bookmark items open context menu.

This CL makes the context menu for bookmark items appear when an item is
clicked.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2814023004
Cr-Commit-Position: refs/heads/master@{#469281}
Committed:
https://chromium.googlesource.com/chromium/src/+/a32022824f01698ab161130a96c2...
==========

[commit-bot: I haz the power, 2017-05-04 06:01:02]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a32022824f01698ab161130a96c2...