Chromium Code Reviews
Help | Chromium Project | Sign in
(20)

Issue 2814023004: [MD Bookmarks] Right click on bookmark items open context menu.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by calamity
Modified:
5 days, 22 hours ago
Reviewers:
tsergeant
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Right click on bookmark items open context menu. This CL makes the context menu for bookmark items appear when an item is clicked. BUG=692837 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : address_comments #

Total comments: 2

Patch Set 4 : fix_nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -3 lines) Patch
M chrome/browser/resources/md_bookmarks/item.js View 1 2 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/list.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/list.js View 1 2 3 2 chunks +22 lines, -1 line 0 comments Download
M chrome/test/data/webui/md_bookmarks/item_test.js View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Depends on Patchset:

Messages

Total messages: 16 (11 generated)
calamity
1 week, 5 days ago (2017-04-12 09:47:10 UTC) #3
tsergeant
Neat! https://codereview.chromium.org/2814023004/diff/1/chrome/browser/resources/md_bookmarks/item.js File chrome/browser/resources/md_bookmarks/item.js (right): https://codereview.chromium.org/2814023004/diff/1/chrome/browser/resources/md_bookmarks/item.js#newcode66 chrome/browser/resources/md_bookmarks/item.js:66: e.preventDefault(); Minor suggestion: you should select the item ...
1 week, 5 days ago (2017-04-13 01:15:47 UTC) #4
calamity
https://codereview.chromium.org/2814023004/diff/1/chrome/browser/resources/md_bookmarks/item.js File chrome/browser/resources/md_bookmarks/item.js (right): https://codereview.chromium.org/2814023004/diff/1/chrome/browser/resources/md_bookmarks/item.js#newcode66 chrome/browser/resources/md_bookmarks/item.js:66: e.preventDefault(); On 2017/04/13 01:15:47, tsergeant wrote: > Minor suggestion: ...
1 week, 4 days ago (2017-04-13 04:56:46 UTC) #8
tsergeant
lgtm https://codereview.chromium.org/2814023004/diff/60001/chrome/browser/resources/md_bookmarks/list.js File chrome/browser/resources/md_bookmarks/list.js (right): https://codereview.chromium.org/2814023004/diff/60001/chrome/browser/resources/md_bookmarks/list.js#newcode108 chrome/browser/resources/md_bookmarks/list.js:108: this.$.dropdown.close(); nit: call this.closeDropdownMenu_()
1 week, 4 days ago (2017-04-13 05:48:25 UTC) #9
calamity
5 days, 23 hours ago (2017-04-19 05:36:34 UTC) #14
https://codereview.chromium.org/2814023004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/list.js (right):

https://codereview.chromium.org/2814023004/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/list.js:108: this.$.dropdown.close();
On 2017/04/13 05:48:25, tsergeant wrote:
> nit: call this.closeDropdownMenu_()

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46