[turbofan] Properly represent the float64 hole.

[turbofan] Properly represent the float64 hole.

The hole NaN should also have proper Type::Hole, and not silently hide
in the Type::Number. This way we can remove all the special casing for
the hole NaN, and we also finally get the CheckNumber right.

This also allows us to remove some ducktape from the Deoptimizer, as for
escape analyzed FixedDoubleArrays we always pass the hole value now to
represent the actual holes.

Also-By: jarin@chromium.org
BUG=chromium:684208, chromium:709753, v8:5267
R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2814013003
Cr-Commit-Position: refs/heads/master@{#44603}
Committed: https://chromium.googlesource.com/v8/v8/+/8c0c5e8117a0c935d6f2e5f6e540674d46753a87

[Benedikt Meurer, 2017-04-12 07:28:39]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 07:28:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-04-12 07:29:26]

Description was changed from

==========
[turbofan] Properly represent the float64 hole.

The hole NaN should also have proper Type::Hole, and not silently hide
in the Type::Number. This way we can remove all the special casing for
the hole NaN, and we also finally get the CheckNumber right.

This also allows us to remove some ducktape from the Deoptimizer, as for
escape analyzed FixedDoubleArrays we always pass the hole value now to
represent the actual holes.

BUG=chromium:684208,chromium:709753,v8:5267
R=jarin@chromium.org
==========

to

==========
[turbofan] Properly represent the float64 hole.

The hole NaN should also have proper Type::Hole, and not silently hide
in the Type::Number. This way we can remove all the special casing for
the hole NaN, and we also finally get the CheckNumber right.

This also allows us to remove some ducktape from the Deoptimizer, as for
escape analyzed FixedDoubleArrays we always pass the hole value now to
represent the actual holes.

Also-By: jarin@chromium.org
BUG=chromium:684208,chromium:709753,v8:5267
R=jarin@chromium.org
==========

[Benedikt Meurer, 2017-04-12 07:29:41]

Here's the proper fix, based on pair programming approach! :-)

[Jarin, 2017-04-12 07:38:17]

lgtm

[Benedikt Meurer, 2017-04-12 07:38:28]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-04-12 07:38:34]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-04-12 07:38:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 08:05:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 08:05:59]

Try jobs failed on following builders:
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_linux_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng_...)

[Benedikt Meurer, 2017-04-12 08:17:28]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-04-12 08:17:29]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2814013003/#ps20001
(title: "CheckNumber does not need a restriction type.")

[commit-bot: I haz the power, 2017-04-12 08:17:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 09:02:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 09:02:23]

Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/26060)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[Benedikt Meurer, 2017-04-12 09:42:20]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-04-12 09:42:20]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2814013003/#ps40001
(title: "Make sure the_hole has the correct hole NaN bit pattern on Win32.")

[commit-bot: I haz the power, 2017-04-12 09:42:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 10:10:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491990140208060,
"parent_rev": "366f75301d3f17a7df5ed02c5c2972c7c31c9e36", "commit_rev":
"8c0c5e8117a0c935d6f2e5f6e540674d46753a87"}

[commit-bot: I haz the power, 2017-04-12 10:10:55]

Description was changed from

==========
[turbofan] Properly represent the float64 hole.

The hole NaN should also have proper Type::Hole, and not silently hide
in the Type::Number. This way we can remove all the special casing for
the hole NaN, and we also finally get the CheckNumber right.

This also allows us to remove some ducktape from the Deoptimizer, as for
escape analyzed FixedDoubleArrays we always pass the hole value now to
represent the actual holes.

Also-By: jarin@chromium.org
BUG=chromium:684208,chromium:709753,v8:5267
R=jarin@chromium.org
==========

to

==========
[turbofan] Properly represent the float64 hole.

The hole NaN should also have proper Type::Hole, and not silently hide
in the Type::Number. This way we can remove all the special casing for
the hole NaN, and we also finally get the CheckNumber right.

This also allows us to remove some ducktape from the Deoptimizer, as for
escape analyzed FixedDoubleArrays we always pass the hole value now to
represent the actual holes.

Also-By: jarin@chromium.org
BUG=chromium:684208,chromium:709753,v8:5267
R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2814013003
Cr-Commit-Position: refs/heads/master@{#44603}
Committed:
https://chromium.googlesource.com/v8/v8/+/8c0c5e8117a0c935d6f2e5f6e540674d467...
==========

[commit-bot: I haz the power, 2017-04-12 10:10:56]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/8c0c5e8117a0c935d6f2e5f6e540674d467...

[Michael Achenbach, 2017-04-12 10:23:00]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2017-04-12 10:23:01]

https://codereview.chromium.org/2814013003/diff/40001/src/compiler/simplified...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2814013003/diff/40001/src/compiler/simplified...
src/compiler/simplified-lowering.cc:2703: if (truncation.IsUsedAsWord32()) {
FYI: According to (64 bit) coverage bot, this condition has no test coverage. Is
this affecting 32 bit arch only?

[Benedikt Meurer, 2017-04-12 10:24:18]

https://codereview.chromium.org/2814013003/diff/40001/src/compiler/simplified...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2814013003/diff/40001/src/compiler/simplified...
src/compiler/simplified-lowering.cc:2703: if (truncation.IsUsedAsWord32()) {
Not necessarily.