Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2813983002: Set WebViewImpl's size in OOPIF processes. (Closed)

Created:
3 years, 8 months ago by kenrb
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Set WebViewImpl's size in OOPIF processes. In an OOPIF process with a remote main frame, currently the size of the WebViewImpl is not set, because it is not relevant when there is no main frame to render. However, the VisualViewport size is required so OOPIF resizes set it appropriately. This has caused a problem during printing because it saves and then restores the WebViewImpl size, which unfortunately also wipes out the VisualViewport size. This CL sets the WebViewImpl size along with the VisualViewport in order to keep them consistent. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation BUG=705867 Review-Url: https://codereview.chromium.org/2801143002 Cr-Commit-Position: refs/heads/master@{#462927} (cherry picked from commit 931d158f73d21b37bad43543239a7da2f587ff0e) Review-Url: https://codereview.chromium.org/2813983002 . Cr-Commit-Position: refs/branch-heads/3029@{#669} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/814a02571cf378f27f0d9e160b284dcc55163b99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kenrb
3 years, 8 months ago (2017-04-11 21:33:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
814a02571cf378f27f0d9e160b284dcc55163b99.

Powered by Google App Engine
This is Rietveld 408576698