Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2813963003: MD Settings: fix paper-input label line-height (Closed)

Created:
3 years, 8 months ago by scottchen
Modified:
3 years, 8 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix paper-input label line-height BUG=701284 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2813963003 Cr-Commit-Position: refs/heads/master@{#464550} Committed: https://chromium.googlesource.com/chromium/src/+/01290e8c82c71cec17fc4c15773aa21d0ee26306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/settings_vars_css.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
scottchen
I did my math wrong the first time - got thrown off by paper-input-label's scale(75%)... ...
3 years, 8 months ago (2017-04-12 01:53:31 UTC) #3
tommycli
lgtm i can confirm that then new setting fixes it.
3 years, 8 months ago (2017-04-12 15:47:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813963003/1
3 years, 8 months ago (2017-04-13 20:19:45 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 21:29:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/01290e8c82c71cec17fc4c15773a...

Powered by Google App Engine
This is Rietveld 408576698