Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2813943002: Drop the const modifier on NotificationDisplayService::GetDisplayed (Closed)

Created:
3 years, 8 months ago by Peter Beverloo
Modified:
3 years, 8 months ago
Reviewers:
Miguel Garcia, dewittj
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop the const modifier on NotificationDisplayService::GetDisplayed The interface cannot guarantee that none of the implementations may need to update state to get the list of displayed notification ids. BUG= Review-Url: https://codereview.chromium.org/2813943002 Cr-Commit-Position: refs/heads/master@{#463787} Committed: https://chromium.googlesource.com/chromium/src/+/b5298ae4843e7de650c6762efcbc0ffbf1f14770

Patch Set 1 #

Patch Set 2 : sync and rebase #

Messages

Total messages: 18 (13 generated)
Peter Beverloo
+dewittj, miguelg - PTAL
3 years, 8 months ago (2017-04-11 18:32:23 UTC) #4
Miguel Garcia
lgtm
3 years, 8 months ago (2017-04-11 19:52:30 UTC) #12
dewittj
lgtm
3 years, 8 months ago (2017-04-11 20:08:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813943002/20001
3 years, 8 months ago (2017-04-11 21:05:51 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 21:53:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b5298ae4843e7de650c6762efcbc...

Powered by Google App Engine
This is Rietveld 408576698