Adds target for ash_mus_unittests filter file

Adds target for ash_mus_unittests filter file

Hopefully this makes it so the swarming targets get the filter file.

BUG=705715
TEST=this is test change
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2813923002
Cr-Commit-Position: refs/heads/master@{#463741}
Committed: https://chromium.googlesource.com/chromium/src/+/fcfbb28d15e624ef7e4efe48c3a3086d4777d03a

[sky, 2017-04-11 18:02:51]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 18:03:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-04-11 18:13:06]

I suppose this is one way to do it, and I don't have an immediately obviously
better way in mind.

lgtm.

[sky, 2017-04-11 18:19:48]

AFAICT this seems to be the way we get swarming to know about testing
files... OTOH it does seem weird to me that targets have to know about
these filter files. Seems better to have swarming suck in all the filter
files.

On Tue, Apr 11, 2017 at 11:13 AM, <dpranke@chromium.org> wrote:

> I suppose this is one way to do it, and I don't have an immediately
> obviously
> better way in mind.
>
> lgtm.
>
> https://codereview.chromium.org/2813923002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2017-04-11 18:19:58]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-04-11 18:20:02]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-04-11 18:20:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-04-11 18:26:44]

A more common way to do it (I think) is to create a separate
group("ash_mus_unittests") { data = [ ".../ash_mus_unittests.filter" ]}, and
then do the gn_isolate_map dance like you were doing before. However, it'd be
good to have a more standardized (and cleaner) way to do things.

I don't think we want swarming just grabbing whole sets of files; it seems
better to specify the exact dependencies where we can.

[sky, 2017-04-11 19:07:37]

Does swarming already pull in some test directories such as
chrome/test/data?

On Tue, Apr 11, 2017 at 11:26 AM, <dpranke@chromium.org> wrote:

> A more common way to do it (I think) is to create a separate
> group("ash_mus_unittests") { data = [ ".../ash_mus_unittests.filter" ]},
> and
> then do the gn_isolate_map dance like you were doing before. However, it'd
> be
> good to have a more standardized (and cleaner) way to do things.
>
> I don't think we want swarming just grabbing whole sets of files; it seems
> better to specify the exact dependencies where we can.
>
> https://codereview.chromium.org/2813923002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dirk Pranke, 2017-04-11 19:47:34]

On 2017/04/11 19:07:37, sky wrote:
> Does swarming already pull in some test directories such as
> chrome/test/data?

No. By design, swarming pulls in nothing by default. MB, when
it runs, adds in a few files to every isolate (like //testing/test_env.py
and //testing/xvfb.py if necessary), but we should really get rid of
that logic and *only* use the logic in the GN files.

[commit-bot: I haz the power, 2017-04-11 20:06:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491934802738730, "parent_rev":
"1cc94fe3b88dc9f048d4fce8c8814fd334d120d1", "commit_rev":
"fcfbb28d15e624ef7e4efe48c3a3086d4777d03a"}

[commit-bot: I haz the power, 2017-04-11 20:07:24]

Description was changed from

==========
Adds target for ash_mus_unittests filter file

Hopefully this makes it so the swarming targets get the filter file.

BUG=705715
TEST=this is test change
R=dpranke@chromium.org
==========

to

==========
Adds target for ash_mus_unittests filter file

Hopefully this makes it so the swarming targets get the filter file.

BUG=705715
TEST=this is test change
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2813923002
Cr-Commit-Position: refs/heads/master@{#463741}
Committed:
https://chromium.googlesource.com/chromium/src/+/fcfbb28d15e624ef7e4efe48c3a3...
==========

[commit-bot: I haz the power, 2017-04-11 20:07:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fcfbb28d15e624ef7e4efe48c3a3...