Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2813903003: Process a pair of registers in one instruction where possible on arm in the VM. (Closed)

Created:
3 years, 8 months ago by regis
Modified:
3 years, 8 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Process a pair of registers in one instruction where possible on arm in the VM. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/d8c17c90f25bfd1af65c3c00013844b193e5b8b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -94 lines) Patch
M runtime/vm/flow_graph_compiler_arm.cc View 16 chunks +52 lines, -64 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 9 chunks +17 lines, -20 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 6 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
3 years, 8 months ago (2017-04-11 17:22:18 UTC) #2
zra
lgtm Thanks!
3 years, 8 months ago (2017-04-11 17:28:15 UTC) #3
regis
3 years, 8 months ago (2017-04-11 17:48:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d8c17c90f25bfd1af65c3c00013844b193e5b8b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698