Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: runtime/vm/stub_code_arm.cc

Issue 2813903003: Process a pair of registers in one instruction where possible on arm in the VM. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_arm.cc
diff --git a/runtime/vm/stub_code_arm.cc b/runtime/vm/stub_code_arm.cc
index 27fa1f469b50e524af2479c0e167249b970bc328..d8cf21cb95914ba70e13edbfaec9469fa3bc2d67 100644
--- a/runtime/vm/stub_code_arm.cc
+++ b/runtime/vm/stub_code_arm.cc
@@ -1754,8 +1754,8 @@ void StubCode::GenerateDebugStepCheckStub(Assembler* assembler) {
// Used to check class and type arguments. Arguments passed in registers:
// LR: return address.
// R0: instance (must be preserved).
-// R1: instantiator type arguments (only if n == 4, can be raw_null).
-// R2: function type arguments (only if n == 4, can be raw_null).
+// R2: instantiator type arguments (only if n == 4, can be raw_null).
+// R1: function type arguments (only if n == 4, can be raw_null).
// R3: SubtypeTestCache.
// Result in R1: null -> not found, otherwise result (true or false).
static void GenerateSubtypeNTestCacheStub(Assembler* assembler, int n) {
@@ -1775,8 +1775,8 @@ static void GenerateSubtypeNTestCacheStub(Assembler* assembler, int n) {
}
__ LoadClassId(R8, R0);
// R0: instance.
- // R1: instantiator type arguments (only if n == 4, can be raw_null).
- // R2: function type arguments (only if n == 4, can be raw_null).
+ // R2: instantiator type arguments (only if n == 4, can be raw_null).
+ // R1: function type arguments (only if n == 4, can be raw_null).
// R3: SubtypeTestCache.
// R8: instance class id.
// R4: instance type arguments (null if none), used only if n > 1.
@@ -1811,11 +1811,11 @@ static void GenerateSubtypeNTestCacheStub(Assembler* assembler, int n) {
__ b(&next_iteration, NE);
__ ldr(R9, Address(R3, kWordSize *
SubtypeTestCache::kInstantiatorTypeArguments));
- __ cmp(R9, Operand(R1));
+ __ cmp(R9, Operand(R2));
__ b(&next_iteration, NE);
__ ldr(R9,
Address(R3, kWordSize * SubtypeTestCache::kFunctionTypeArguments));
- __ cmp(R9, Operand(R2));
+ __ cmp(R9, Operand(R1));
__ b(&found, EQ);
}
}
@@ -1836,8 +1836,8 @@ static void GenerateSubtypeNTestCacheStub(Assembler* assembler, int n) {
// Used to check class and type arguments. Arguments passed in registers:
// LR: return address.
// R0: instance (must be preserved).
-// R1: unused.
// R2: unused.
+// R1: unused.
// R3: SubtypeTestCache.
// Result in R1: null -> not found, otherwise result (true or false).
void StubCode::GenerateSubtype1TestCacheStub(Assembler* assembler) {
@@ -1848,8 +1848,8 @@ void StubCode::GenerateSubtype1TestCacheStub(Assembler* assembler) {
// Used to check class and type arguments. Arguments passed in registers:
// LR: return address.
// R0: instance (must be preserved).
-// R1: unused.
// R2: unused.
+// R1: unused.
// R3: SubtypeTestCache.
// Result in R1: null -> not found, otherwise result (true or false).
void StubCode::GenerateSubtype2TestCacheStub(Assembler* assembler) {
@@ -1860,8 +1860,8 @@ void StubCode::GenerateSubtype2TestCacheStub(Assembler* assembler) {
// Used to check class and type arguments. Arguments passed in registers:
// LR: return address.
// R0: instance (must be preserved).
-// R1: instantiator type arguments (can be raw_null).
-// R2: function type arguments (can be raw_null).
+// R2: instantiator type arguments (can be raw_null).
+// R1: function type arguments (can be raw_null).
// R3: SubtypeTestCache.
// Result in R1: null -> not found, otherwise result (true or false).
void StubCode::GenerateSubtype4TestCacheStub(Assembler* assembler) {
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698