Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2813893005: Add Flash to the PermissionRequestType histogram enum (Closed)

Created:
3 years, 8 months ago by benwells
Modified:
3 years, 8 months ago
Reviewers:
raymes, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Flash to the PermissionRequestType histogram enum This was added to the PermissionRequestType enum for the HTML By Default project but histograms.xml wasn't updated to match. BUG=None Review-Url: https://codereview.chromium.org/2813893005 Cr-Commit-Position: refs/heads/master@{#464286} Committed: https://chromium.googlesource.com/chromium/src/+/caa1091521ea95e80098fc99449c556d2c9fb28e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
benwells
3 years, 8 months ago (2017-04-12 07:14:17 UTC) #2
raymes
lgtm, thanks!
3 years, 8 months ago (2017-04-12 21:57:36 UTC) #3
Ilya Sherman
LGTM
3 years, 8 months ago (2017-04-12 22:15:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813893005/1
3 years, 8 months ago (2017-04-13 01:00:12 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 03:53:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/caa1091521ea95e80098fc99449c...

Powered by Google App Engine
This is Rietveld 408576698