Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2813893002: [regexp] Consider surrogate pairs when optimizing disjunctions (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Consider surrogate pairs when optimizing disjunctions RationalizeConsecutiveAtoms optimizes ab|ac|az to a(?:b|c|d). Ensure that this optimization does not split surrogate pairs in unicode mode. BUG=chromium:641091 Review-Url: https://codereview.chromium.org/2813893002 Cr-Commit-Position: refs/heads/master@{#44599} Committed: https://chromium.googlesource.com/v8/v8/+/4635572471b28a38f04307fabc69d5e1802d1049

Patch Set 1 #

Patch Set 2 : Address offline comments #

Patch Set 3 : Rebase #

Patch Set 4 : DCHECK(!IsLeadSurrogate) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -24 lines) Patch
M src/regexp/jsregexp.cc View 1 2 3 8 chunks +23 lines, -13 lines 0 comments Download
M src/regexp/regexp-ast.h View 1 2 chunks +19 lines, -5 lines 0 comments Download
M src/regexp/regexp-parser.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download
A test/mjsunit/regress/regress-641091.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
jgruber
3 years, 8 months ago (2017-04-11 15:02:24 UTC) #4
Yang
On 2017/04/11 15:02:24, jgruber wrote: lgtm.
3 years, 8 months ago (2017-04-12 06:38:10 UTC) #7
Yang
On 2017/04/12 06:38:10, Yang wrote: > On 2017/04/11 15:02:24, jgruber wrote: > > lgtm. still ...
3 years, 8 months ago (2017-04-12 09:06:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813893002/60001
3 years, 8 months ago (2017-04-12 09:07:14 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 09:09:18 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/4635572471b28a38f04307fabc69d5e1802...

Powered by Google App Engine
This is Rietveld 408576698