Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Issue 2813883005: Remove ClearSelection() from DragCaret::NodeWillBeRemoved() (Closed)

Created:
3 years, 8 months ago by yoichio
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ClearSelection() from DragCaret::NodeWillBeRemoved() This line was introduced before 2011 splitting DragCaretController from FrameSelection: https://chromium.googlesource.com/chromium/src/+/fa14cd2b25316fb358f7f5ebc16f752ebcb4093a Now DragCaret doesn't touch Selection Layout and this is unnecessary call. BUG=708453 Review-Url: https://codereview.chromium.org/2813883005 Cr-Commit-Position: refs/heads/master@{#464356} Committed: https://chromium.googlesource.com/chromium/src/+/e5d560486bf5b9e6880ad8501bf1e6b8af3a0e2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/DragCaret.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yoichio
3 years, 8 months ago (2017-04-13 08:58:07 UTC) #8
yosin_UTC9
lgtm Good catch!
3 years, 8 months ago (2017-04-13 09:01:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813883005/1
3 years, 8 months ago (2017-04-13 09:02:24 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 09:23:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5d560486bf5b9e6880ad8501bf1...

Powered by Google App Engine
This is Rietveld 408576698