Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html

Issue 2813883004: Remove RTCIceTransportPolicy "none". (Closed)
Patch Set: Updated failing tests in RTCPeerConnection.html Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
index ca6e780854dab4994b67dbc139e99155d9cebb37..d8976863dbb15b850ff13149937b1c4cabcd7be0 100644
--- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
+++ b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
@@ -31,9 +31,15 @@ shouldThrow("new RTCPeerConnection({iceServers:[{url:'foo'}]});");
shouldThrow("new RTCPeerConnection({iceServers:[{urls:'unsupported:scheme'}]});");
shouldThrow("new RTCPeerConnection({iceServers:[{urls:[1, 'turn:foo.com']}]});");
-shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransports:'none'});");
+shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransportPolicy:'relay'});");
foolip 2017/04/21 16:14:29 This is fine, but over time I think LayoutTests/fa
+shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransportPolicy:'all'});");
+shouldThrow("new RTCPeerConnection({iceServers:[], iceTransportPolicy:'none'});");
+shouldThrow("new RTCPeerConnection({iceServers:[], iceTransportPolicy:'foo'});");
+
+// TODO(foolip): |iceTransports| is not in the spec.
shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransports:'relay'});");
shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransports:'all'});");
+shouldThrow("new RTCPeerConnection({iceServers:[], iceTransports:'none'});");
shouldThrow("new RTCPeerConnection({iceServers:[], iceTransports:'foo'});");
shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'balanced'});");

Powered by Google App Engine
This is Rietveld 408576698