third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html - Issue 2813883004: Remove RTCIceTransportPolicy "none".

Side by Side Diff: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html

Issue 2813883004: Remove RTCIceTransportPolicy "none". (Closed)

Patch Set: Updated failing tests in RTCPeerConnection.html Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8 description("Tests the RTCPeerConnection constructor.");	8 description("Tests the RTCPeerConnection constructor.");

9	9

10 shouldBe("webkitRTCPeerConnection", "RTCPeerConnection");	10 shouldBe("webkitRTCPeerConnection", "RTCPeerConnection");

(...skipping 13 matching lines...) Expand all Loading...
24 shouldThrow("new RTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:foo .com']}]});");	24 shouldThrow("new RTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:foo .com']}]});");

25	25

26 shouldNotThrow("new RTCPeerConnection({fooServers:[]});");	26 shouldNotThrow("new RTCPeerConnection({fooServers:[]});");

27 shouldThrow("new RTCPeerConnection({iceServers:true});");	27 shouldThrow("new RTCPeerConnection({iceServers:true});");

28 shouldThrow("new RTCPeerConnection({iceServers:[1, 2, 3]});");	28 shouldThrow("new RTCPeerConnection({iceServers:[1, 2, 3]});");

29 shouldThrow("new RTCPeerConnection({iceServers:[{}]});");	29 shouldThrow("new RTCPeerConnection({iceServers:[{}]});");

30 shouldThrow("new RTCPeerConnection({iceServers:[{url:'foo'}]});");	30 shouldThrow("new RTCPeerConnection({iceServers:[{url:'foo'}]});");

31 shouldThrow("new RTCPeerConnection({iceServers:[{urls:'unsupported:scheme'}]});" );	31 shouldThrow("new RTCPeerConnection({iceServers:[{urls:'unsupported:scheme'}]});" );

32 shouldThrow("new RTCPeerConnection({iceServers:[{urls:[1, 'turn:foo.com']}]});") ;	32 shouldThrow("new RTCPeerConnection({iceServers:[{urls:[1, 'turn:foo.com']}]});") ;

33	33

34 shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransports:'none'});");	34 shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransportPolicy:'relay' });");
	foolip 2017/04/21 16:14:29 This is fine, but over time I think LayoutTests/fa This is fine, but over time I think LayoutTests/fast/peerconnection/ must be reconciled with LayoutTests/external/wpt/webrtc/, so making changes just to wpt and where possible removing duplicate coverage would be my strategy.
	35 shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransportPolicy:'all'}) ;");

	36 shouldThrow("new RTCPeerConnection({iceServers:[], iceTransportPolicy:'none'});" );

	37 shouldThrow("new RTCPeerConnection({iceServers:[], iceTransportPolicy:'foo'});") ;

	38

	39 // TODO(foolip): \|iceTransports\| is not in the spec.

35 shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransports:'relay'});") ;	40 shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransports:'relay'});") ;

36 shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransports:'all'});");	41 shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransports:'all'});");

	42 shouldThrow("new RTCPeerConnection({iceServers:[], iceTransports:'none'});");

37 shouldThrow("new RTCPeerConnection({iceServers:[], iceTransports:'foo'});");	43 shouldThrow("new RTCPeerConnection({iceServers:[], iceTransports:'foo'});");

38	44

39 shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'balanced'}); ");	45 shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'balanced'}); ");

40 shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'max-bundle'} );");	46 shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'max-bundle'} );");

41 shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'max-compat'} );");	47 shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'max-compat'} );");

42 shouldThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'foo'});");	48 shouldThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'foo'});");

43	49

44 shouldNotThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'negotiate'} );");	50 shouldNotThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'negotiate'} );");

45 shouldNotThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'require'}); ");	51 shouldNotThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'require'}); ");

46 shouldThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'foo'});");	52 shouldThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'foo'});");

(...skipping 77 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
124 }	130 }

125 // Sequentially test construction with RSA and ECDSA certificates.	131 // Sequentially test construction with RSA and ECDSA certificates.

126 // testCertificates3Expired's callback methods mark the end of the async tests.	132 // testCertificates3Expired's callback methods mark the end of the async tests.

127 testCertificates1RSA();	133 testCertificates1RSA();

128	134

129 window.jsTestIsAsync = true;	135 window.jsTestIsAsync = true;

130 window.successfullyParsed = true;	136 window.successfullyParsed = true;

131 </script>	137 </script>

132 </body>	138 </body>

133 </html>	139 </html>

OLD	NEW