third_party/WebKit/LayoutTests/storage/indexeddb/cursor-request-cycle.html - Issue 2813873002: Modify some more GC layout tests to work with Ignition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/storage/indexeddb/cursor-request-cycle.html

Issue 2813873002: Modify some more GC layout tests to work with Ignition (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/netinfo/gc-unused-listeners.html ('k') | third_party/WebKit/LayoutTests/storage/indexeddb/key-cursor-request-cycle.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/storage/indexeddb/cursor-request-cycle.html

diff --git a/third_party/WebKit/LayoutTests/storage/indexeddb/cursor-request-cycle.html b/third_party/WebKit/LayoutTests/storage/indexeddb/cursor-request-cycle.html

index 4f65843e93caec4a4234c6cc3782723d4bd306c9..1d09df928c29d873c983203b75be030904858559 100644

--- a/third_party/WebKit/LayoutTests/storage/indexeddb/cursor-request-cycle.html

+++ b/third_party/WebKit/LayoutTests/storage/indexeddb/cursor-request-cycle.html

@@ -73,7 +73,10 @@ function onOpen(evt)

shouldBeEqualToString("cursor.key", "key2");

shouldBeEqualToString("cursor.value", "value2");

- cursorObservation = internals.observeGC(cursor);

+ // Access objects in an inner function to avoid references to

+ // objects remaining live on this function's stack frame

+ // (http://crbug.com/595672/).

+ (() => { cursorObservation = internals.observeGC(cursor); })();

evalAndLog("cursor = null");

evalAndLog("gc()");

shouldBeTrue("cursorRequestObservation.wasCollected");