Issue 2813853002: Use entity WorldImpl where possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2813853002: Use entity WorldImpl where possible (Closed)

Created:
3 years, 8 months ago by Johnni Winther

Modified:
3 years, 8 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Use entity WorldImpl where possible This is a step towards making WorldImpl reusable for kernel based elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/5c0566c47677b1cb4b5e19cdd968533318ca3f6e

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+187 lines, -213 lines)			Patch
M	pkg/compiler/lib/src/universe/class_set.dart	View	23 chunks	+28 lines, -30 lines	0 comments	Download
M	pkg/compiler/lib/src/world.dart	View	26 chunks	+119 lines, -130 lines	0 comments	Download
M	tests/compiler/dart2js/kernel/closed_world2_test.dart	View	4 chunks	+9 lines, -22 lines	0 comments	Download
M	tests/compiler/dart2js/world_test.dart	View	13 chunks	+31 lines, -31 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

3 years, 8 months ago (2017-04-12 07:29:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5c0566c47677b1cb4b5e19cdd968533318ca3f6e (presubmit successful).