Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: tests/compiler/dart2js/kernel/closed_world2_test.dart

Issue 2813853002: Use entity WorldImpl where possible (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/world.dart ('k') | tests/compiler/dart2js/world_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/kernel/closed_world2_test.dart
diff --git a/tests/compiler/dart2js/kernel/closed_world2_test.dart b/tests/compiler/dart2js/kernel/closed_world2_test.dart
index d1d45241e32f9356de297609aab24bf57df6ba7f..0a0213908355c33f1e57c3802f84eb433de1db8e 100644
--- a/tests/compiler/dart2js/kernel/closed_world2_test.dart
+++ b/tests/compiler/dart2js/kernel/closed_world2_test.dart
@@ -75,8 +75,8 @@ main(List<String> args) {
KernelWorldBuilder worldBuilder = new KernelWorldBuilder(
compiler.reporter, compiler.backend.kernelTask.program);
- List list = createKernelResolutionEnqueuerListener(
- compiler.options, compiler.deferredLoadTask, worldBuilder);
+ List list = createKernelResolutionEnqueuerListener(compiler.options,
+ compiler.reporter, compiler.deferredLoadTask, worldBuilder);
ResolutionEnqueuerListener resolutionEnqueuerListener = list[0];
ImpactTransformer impactTransformer = list[1];
ResolutionEnqueuer enqueuer = new ResolutionEnqueuer(
@@ -98,8 +98,11 @@ main(List<String> args) {
});
}
-List createKernelResolutionEnqueuerListener(CompilerOptions options,
- DeferredLoadTask deferredLoadTask, KernelWorldBuilder worldBuilder) {
+List createKernelResolutionEnqueuerListener(
+ CompilerOptions options,
+ DiagnosticReporter reporter,
+ DeferredLoadTask deferredLoadTask,
+ KernelWorldBuilder worldBuilder) {
ElementEnvironment elementEnvironment = worldBuilder.elementEnvironment;
CommonElements commonElements = worldBuilder.commonElements;
BackendHelpers helpers =
@@ -112,11 +115,11 @@ List createKernelResolutionEnqueuerListener(CompilerOptions options,
MirrorsDataBuilder mirrorsDataBuilder = new MirrorsDataBuilderImpl();
CustomElementsResolutionAnalysis customElementsResolutionAnalysis =
new CustomElementsResolutionAnalysisImpl();
- LookupMapResolutionAnalysis lookupMapResolutionAnalysis =
- new LookupMapResolutionAnalysisImpl();
MirrorsResolutionAnalysis mirrorsResolutionAnalysis =
new MirrorsResolutionAnalysisImpl();
+ LookupMapResolutionAnalysis lookupMapResolutionAnalysis =
+ new LookupMapResolutionAnalysis(reporter, elementEnvironment);
BackendClasses backendClasses = new JavaScriptBackendClasses(
elementEnvironment, helpers, nativeBasicData);
InterceptorDataBuilder interceptorDataBuilder =
@@ -272,22 +275,6 @@ class CustomElementsResolutionAnalysisImpl
void registerTypeLiteral(DartType type) {}
}
-class LookupMapResolutionAnalysisImpl implements LookupMapResolutionAnalysis {
- @override
- FieldEntity lookupMapVersionVariable;
- @override
- LibraryEntity lookupMapLibrary;
-
- @override
- WorldImpact flush() {
- // TODO(johnniwinther): Implement this.
- return const WorldImpact();
- }
-
- @override
- void init(LibraryEntity library) {}
-}
-
class MirrorsResolutionAnalysisImpl implements MirrorsResolutionAnalysis {
@override
void onQueueEmpty(Enqueuer enqueuer, Iterable<ClassEntity> recentClasses) {}
« no previous file with comments | « pkg/compiler/lib/src/world.dart ('k') | tests/compiler/dart2js/world_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698