Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2813823004: Make two promise-related tests deterministic (Closed)

Created:
3 years, 8 months ago by Sami
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make two promise-related tests deterministic Promise rejections are implemented by a posting a trampoline task after running microtasks[1]. A timer scheduled in the task preceding the microtasks isn't guaranteed to run after this task, so the tests also need to be changed to use a nested trampoline to ensure rejection has taken place before verifying test invariants. [1] Since https://codereview.chromium.org/1381693002/ BUG=696001 Review-Url: https://codereview.chromium.org/2813823004 Cr-Commit-Position: refs/heads/master@{#463997} Committed: https://chromium.googlesource.com/chromium/src/+/f6a46ccf800d58cb3ff9b8c4d19eb8eee330d4d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events-onerror.html View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/promise-access-control-deny.html View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Sami
Jochen, wanna check this since you changed the behavior (only 1½ years ago :)?
3 years, 8 months ago (2017-04-12 10:22:40 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-12 10:30:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813823004/1
3 years, 8 months ago (2017-04-12 11:41:51 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 11:52:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f6a46ccf800d58cb3ff9b8c4d19e...

Powered by Google App Engine
This is Rietveld 408576698