Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2813803002: [MD settings] vertical align left edge of icons and text (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] vertical align left edge of icons and text This CL moves spacing around so that icons and text vertically align on the left edge. The old indent was 56px and the new indent is 60px. BUG=709654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2813803002 Cr-Commit-Position: refs/heads/master@{#463696} Committed: https://chromium.googlesource.com/chromium/src/+/8ee0be28f0383dc0c4e5a6062bf7dd87df956cbd

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -29 lines) Patch
M chrome/browser/resources/settings/languages_page/edit_dictionary_page.html View 1 chunk +20 lines, -20 lines 1 comment Download
M chrome/browser/resources/settings/people_page/users_page.html View 1 chunk +2 lines, -0 lines 1 comment Download
M chrome/browser/resources/settings/settings_page/settings_subpage.html View 2 chunks +2 lines, -6 lines 1 comment Download
M chrome/browser/resources/settings/settings_shared_css.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_vars_css.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
dschuyler
https://codereview.chromium.org/2813803002/diff/1/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html File chrome/browser/resources/settings/languages_page/edit_dictionary_page.html (right): https://codereview.chromium.org/2813803002/diff/1/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html#newcode47 chrome/browser/resources/settings/languages_page/edit_dictionary_page.html:47: </div> Moving this </div> is the change. The list-frame ...
3 years, 8 months ago (2017-04-11 01:11:19 UTC) #5
dschuyler
Steven, heard you were rather busy. This CL doesn't need your specific attention.
3 years, 8 months ago (2017-04-11 01:15:36 UTC) #7
Dan Beam
lgtm
3 years, 8 months ago (2017-04-11 01:21:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813803002/1
3 years, 8 months ago (2017-04-11 18:15:12 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 18:37:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ee0be28f0383dc0c4e5a6062bf7...

Powered by Google App Engine
This is Rietveld 408576698