Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2813703002: [ObjC ARC] Converts components/translate/ios/browser:unit_tests to ARC. (Closed)

Created:
3 years, 8 months ago by stkhapugin
Modified:
3 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts components/translate/ios/browser:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2813703002 Cr-Commit-Position: refs/heads/master@{#463654} Committed: https://chromium.googlesource.com/chromium/src/+/8917080a3615f02c2346ec29b56c2931a9b6783b

Patch Set 1 #

Total comments: 4

Patch Set 2 : make_unique #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -15 lines) Patch
M components/translate/ios/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/translate/ios/browser/js_translate_manager_unittest.mm View 4 chunks +8 lines, -5 lines 0 comments Download
M components/translate/ios/browser/language_detection_controller_unittest.mm View 1 4 chunks +10 lines, -5 lines 0 comments Download
M components/translate/ios/browser/translate_controller_unittest.mm View 1 4 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
stkhapugin
PTAL
3 years, 8 months ago (2017-04-10 17:01:51 UTC) #4
sdefresne
lgtm https://codereview.chromium.org/2813703002/diff/1/components/translate/ios/browser/language_detection_controller_unittest.mm File components/translate/ios/browser/language_detection_controller_unittest.mm (right): https://codereview.chromium.org/2813703002/diff/1/components/translate/ios/browser/language_detection_controller_unittest.mm#newcode43 components/translate/ios/browser/language_detection_controller_unittest.mm:43: new LanguageDetectionController(&web_state_, js_manager, &prefs_)); Please use the opportunity ...
3 years, 8 months ago (2017-04-11 07:45:33 UTC) #7
stkhapugin
Thank you! https://codereview.chromium.org/2813703002/diff/1/components/translate/ios/browser/language_detection_controller_unittest.mm File components/translate/ios/browser/language_detection_controller_unittest.mm (right): https://codereview.chromium.org/2813703002/diff/1/components/translate/ios/browser/language_detection_controller_unittest.mm#newcode43 components/translate/ios/browser/language_detection_controller_unittest.mm:43: new LanguageDetectionController(&web_state_, js_manager, &prefs_)); On 2017/04/11 07:45:32, ...
3 years, 8 months ago (2017-04-11 15:33:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813703002/20001
3 years, 8 months ago (2017-04-11 15:34:03 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 16:38:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8917080a3615f02c2346ec29b56c...

Powered by Google App Engine
This is Rietveld 408576698