Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2813643002: Change the distance trigger scrollbar show (Closed)

Created:
3 years, 8 months ago by chaopeng
Modified:
3 years, 8 months ago
Reviewers:
bokan, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the distance trigger scrollbar show We used to calculate the distance from edge to trigger scrollbar show. Now change to use the distance from scrollbar to trigger scrollbar show. BUG=709700 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2813643002 Cr-Commit-Position: refs/heads/master@{#464125} Committed: https://chromium.googlesource.com/chromium/src/+/07077943755bf2cf166a2fe8c2aaab6fd46142b6

Patch Set 1 #

Total comments: 1

Patch Set 2 : change tests and comments #

Total comments: 2

Patch Set 3 : update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M cc/input/scrollbar_animation_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/input/scrollbar_animation_controller_unittest.cc View 1 2 5 chunks +25 lines, -18 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
chaopeng
PTAL. Thank you.
3 years, 8 months ago (2017-04-10 14:14:21 UTC) #3
bokan
https://codereview.chromium.org/2813643002/diff/1/cc/input/scrollbar_animation_controller_unittest.cc File cc/input/scrollbar_animation_controller_unittest.cc (right): https://codereview.chromium.org/2813643002/diff/1/cc/input/scrollbar_animation_controller_unittest.cc#newcode1036 cc/input/scrollbar_animation_controller_unittest.cc:1036: scrollbar_controller_->DidMouseMoveNear(VERTICAL, 0); This should be kMouseMoveDistanceToTriggerShow - 1. in ...
3 years, 8 months ago (2017-04-10 14:30:18 UTC) #4
chaopeng
Updated. PTAL. https://codereview.chromium.org/2813643002/diff/20001/cc/input/scrollbar_animation_controller_unittest.cc File cc/input/scrollbar_animation_controller_unittest.cc (right): https://codereview.chromium.org/2813643002/diff/20001/cc/input/scrollbar_animation_controller_unittest.cc#newcode1010 cc/input/scrollbar_animation_controller_unittest.cc:1010: TEST_F(ScrollbarAnimationControllerAuraOverlayTest, BasicMouseHoverShow) { Here we are not ...
3 years, 8 months ago (2017-04-10 14:56:12 UTC) #5
bokan
lgtm https://codereview.chromium.org/2813643002/diff/20001/cc/input/scrollbar_animation_controller_unittest.cc File cc/input/scrollbar_animation_controller_unittest.cc (right): https://codereview.chromium.org/2813643002/diff/20001/cc/input/scrollbar_animation_controller_unittest.cc#newcode1010 cc/input/scrollbar_animation_controller_unittest.cc:1010: TEST_F(ScrollbarAnimationControllerAuraOverlayTest, BasicMouseHoverShow) { On 2017/04/10 14:56:11, chaopeng wrote: ...
3 years, 8 months ago (2017-04-10 18:14:16 UTC) #6
chaopeng
weiliangc@chromium.org: Please review changes. Thank you.
3 years, 8 months ago (2017-04-10 18:27:10 UTC) #8
weiliangc
LGTM
3 years, 8 months ago (2017-04-12 17:22:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813643002/40001
3 years, 8 months ago (2017-04-12 17:31:47 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 20:07:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/07077943755bf2cf166a2fe8c2aa...

Powered by Google App Engine
This is Rietveld 408576698