Change the distance trigger scrollbar show

Change the distance trigger scrollbar show

We used to calculate the distance from edge to trigger scrollbar show. Now
change to use the distance from scrollbar to trigger scrollbar show.

BUG=709700
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2813643002
Cr-Commit-Position: refs/heads/master@{#464125}
Committed: https://chromium.googlesource.com/chromium/src/+/07077943755bf2cf166a2fe8c2aaab6fd46142b6

[chaopeng, 2017-04-10 14:13:11]

Description was changed from

==========
Change the distance trigger scrollbar show

We used to calculate the distance from edge to trigger scrollbar show. Now
change to use the distance from scrollbar to trigger scrollbar show.

BUG=709700
==========

to

==========
Change the distance trigger scrollbar show

We used to calculate the distance from edge to trigger scrollbar show. Now
change to use the distance from scrollbar to trigger scrollbar show.

BUG=709700
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chaopeng, 2017-04-10 14:14:21]

chaopeng@chromium.org changed reviewers:
+ bokan@chromium.org

[chaopeng, 2017-04-10 14:14:21]

PTAL. Thank you.

[bokan, 2017-04-10 14:30:18]

https://codereview.chromium.org/2813643002/diff/1/cc/input/scrollbar_animatio...
File cc/input/scrollbar_animation_controller_unittest.cc (right):

https://codereview.chromium.org/2813643002/diff/1/cc/input/scrollbar_animatio...
cc/input/scrollbar_animation_controller_unittest.cc:1036:
scrollbar_controller_->DidMouseMoveNear(VERTICAL, 0);
This should be kMouseMoveDistanceToTriggerShow - 1. in order to catch this bug.

[chaopeng, 2017-04-10 14:56:12]

Updated. PTAL.

https://codereview.chromium.org/2813643002/diff/20001/cc/input/scrollbar_anim...
File cc/input/scrollbar_animation_controller_unittest.cc (right):

https://codereview.chromium.org/2813643002/diff/20001/cc/input/scrollbar_anim...
cc/input/scrollbar_animation_controller_unittest.cc:1010:
TEST_F(ScrollbarAnimationControllerAuraOverlayTest, BasicMouseHoverShow) {
Here we are not hover anymore. what should we name this test.

[bokan, 2017-04-10 18:14:16]

lgtm

https://codereview.chromium.org/2813643002/diff/20001/cc/input/scrollbar_anim...
File cc/input/scrollbar_animation_controller_unittest.cc (right):

https://codereview.chromium.org/2813643002/diff/20001/cc/input/scrollbar_anim...
cc/input/scrollbar_animation_controller_unittest.cc:1010:
TEST_F(ScrollbarAnimationControllerAuraOverlayTest, BasicMouseHoverShow) {
On 2017/04/10 14:56:11, chaopeng wrote:
> Here we are not hover anymore. what should we name this test.

We are hovering over the "show scrollbar region" rather than the scrollbar. I
think it's fine but if you want to change to something more descriptive that's
fine too.

[chaopeng, 2017-04-10 18:27:10]

chaopeng@chromium.org changed reviewers:
+ weiliangc@chromium.org

[chaopeng, 2017-04-10 18:27:10]

weiliangc@chromium.org: Please review changes. Thank you.

[weiliangc, 2017-04-12 17:22:50]

LGTM

[chaopeng, 2017-04-12 17:30:42]

The CQ bit was checked by chaopeng@chromium.org

[chaopeng, 2017-04-12 17:30:43]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/2813643002/#ps40001
(title: "update comments")

[commit-bot: I haz the power, 2017-04-12 17:31:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 20:06:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492018242864220,
"parent_rev": "5b24d8b4f3b59e31a689c2defeca8e726f249b79", "commit_rev":
"07077943755bf2cf166a2fe8c2aaab6fd46142b6"}

[commit-bot: I haz the power, 2017-04-12 20:07:22]

Description was changed from

==========
Change the distance trigger scrollbar show

We used to calculate the distance from edge to trigger scrollbar show. Now
change to use the distance from scrollbar to trigger scrollbar show.

BUG=709700
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Change the distance trigger scrollbar show

We used to calculate the distance from edge to trigger scrollbar show. Now
change to use the distance from scrollbar to trigger scrollbar show.

BUG=709700
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2813643002
Cr-Commit-Position: refs/heads/master@{#464125}
Committed:
https://chromium.googlesource.com/chromium/src/+/07077943755bf2cf166a2fe8c2aa...
==========

[commit-bot: I haz the power, 2017-04-12 20:07:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/07077943755bf2cf166a2fe8c2aa...