[csa] Add IsNumber and IsNumberNormalized predicates

[csa] Add IsNumber and IsNumberNormalized predicates

IsNumber returns true for Smi/HeapNumber arguments.

IsNumberNormalized expects a number argument and returns true if
it is either a Smi, or a HeapNumber with a value outside the Smi
range.

BUG=

Review-Url: https://codereview.chromium.org/2813623003
Cr-Commit-Position: refs/heads/master@{#44556}
Committed: https://chromium.googlesource.com/v8/v8/+/ea3bd03945a11bc1f30d926857a911b4159b7628

[jgruber, 2017-04-11 08:21:18]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 08:21:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-11 08:29:04]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 08:29:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-11 08:33:12]

jgruber@chromium.org changed reviewers:
+ cbruni@chromium.org, ishell@chromium.org

[commit-bot: I haz the power, 2017-04-11 08:55:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 08:55:57]

Dry run: This issue passed the CQ dry run.

[cbruni, 2017-04-11 09:10:53]

cbruni@google.com changed reviewers:
+ cbruni@google.com

[cbruni, 2017-04-11 09:10:54]

lgtm

https://codereview.chromium.org/2813623003/diff/20001/src/builtins/builtins-r...
File src/builtins/builtins-regexp-gen.cc (right):

https://codereview.chromium.org/2813623003/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp-gen.cc:1535: CSA_ASSERT(this, IsNumber(index));
nit: not needed then as IsNumberNormalized => IsNumber

[jgruber, 2017-04-11 09:54:58]

https://codereview.chromium.org/2813623003/diff/20001/src/builtins/builtins-r...
File src/builtins/builtins-regexp-gen.cc (right):

https://codereview.chromium.org/2813623003/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp-gen.cc:1535: CSA_ASSERT(this, IsNumber(index));
On 2017/04/11 09:10:54, cbruni wrote:
> nit: not needed then as IsNumberNormalized => IsNumber

Done.

[jgruber, 2017-04-11 09:55:10]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-04-11 09:55:10]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@google.com
Link to the patchset: https://codereview.chromium.org/2813623003/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-04-11 09:55:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 09:55:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 09:55:15]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[Camillo Bruni, 2017-04-11 09:57:07]

lgtm

[Camillo Bruni, 2017-04-11 09:57:36]

On 2017/04/11 at 09:57:07, Camillo Bruni wrote:
> lgtm

sorry... accidentally used my corp account.

[jgruber, 2017-04-11 09:58:22]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-04-11 09:58:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 10:28:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491904702634600,
"parent_rev": "55f5bac450ea4e39bac9fdadc98cbff35d76de08", "commit_rev":
"ea3bd03945a11bc1f30d926857a911b4159b7628"}

[commit-bot: I haz the power, 2017-04-11 10:28:20]

Description was changed from

==========
[csa] Add IsNumber and IsNumberNormalized predicates

IsNumber returns true for Smi/HeapNumber arguments.

IsNumberNormalized expects a number argument and returns true if
it is either a Smi, or a HeapNumber with a value outside the Smi
range.

BUG=
==========

to

==========
[csa] Add IsNumber and IsNumberNormalized predicates

IsNumber returns true for Smi/HeapNumber arguments.

IsNumberNormalized expects a number argument and returns true if
it is either a Smi, or a HeapNumber with a value outside the Smi
range.

BUG=

Review-Url: https://codereview.chromium.org/2813623003
Cr-Commit-Position: refs/heads/master@{#44556}
Committed:
https://chromium.googlesource.com/v8/v8/+/ea3bd03945a11bc1f30d926857a911b4159...
==========

[commit-bot: I haz the power, 2017-04-11 10:28:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/ea3bd03945a11bc1f30d926857a911b4159...