Less direct Compiler use in SSA

Less direct Compiler use in SSA

This is a step towards using data object rather than Compiler and
JavaScriptBackend in codegen. This is needed to support a shift in
element models between resolution and codegen.

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/da22833d8adf088ab9bba07ae8dfa59954b1ea2f

[Johnni Winther, 2017-04-10 13:04:59]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-04-10 19:34:02]

lgtm

https://codereview.chromium.org/2813603002/diff/1/pkg/compiler/lib/src/ssa/gr...
File pkg/compiler/lib/src/ssa/graph_builder.dart (right):

https://codereview.chromium.org/2813603002/diff/1/pkg/compiler/lib/src/ssa/gr...
pkg/compiler/lib/src/ssa/graph_builder.dart:53: CompilerOptions get options =>
compiler.options;
this works, but why not just pass CompilerOptions in when the SsaBuilder and
KernelSsaBuilder are constructed like you've been doing in other parts of the
codebase?

[Johnni Winther, 2017-04-11 07:13:31]

https://codereview.chromium.org/2813603002/diff/1/pkg/compiler/lib/src/ssa/gr...
File pkg/compiler/lib/src/ssa/graph_builder.dart (right):

https://codereview.chromium.org/2813603002/diff/1/pkg/compiler/lib/src/ssa/gr...
pkg/compiler/lib/src/ssa/graph_builder.dart:53: CompilerOptions get options =>
compiler.options;
On 2017/04/10 19:34:02, Emily Fortuna wrote:
> this works, but why not just pass CompilerOptions in when the SsaBuilder and
> KernelSsaBuilder are constructed like you've been doing in other parts of the
> codebase?

This is the plan. I just take small steps.

[Johnni Winther, 2017-04-11 07:36:24]

Description was changed from

==========
Less direct Compiler use in SSA

This is a step towards using data object rather than Compiler and
JavaScriptBackend in codegen. This is needed to support a shift in
element models between resolution and codegen.
==========

to

==========
Less direct Compiler use in SSA

This is a step towards using data object rather than Compiler and
JavaScriptBackend in codegen. This is needed to support a shift in
element models between resolution and codegen.

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/da22833d8adf088ab9bba07ae8dfa59954b1ea2f
==========

[Johnni Winther, 2017-04-11 07:36:28]

Committed patchset #1 (id:1) manually as
da22833d8adf088ab9bba07ae8dfa59954b1ea2f (presubmit successful).