Less direct Compiler use in SSA

pkg/compiler/lib/src/ssa/graph_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import '../common/codegen.dart' show CodegenRegistry;
+import '../common_elements.dart';
 import '../compiler.dart';
+import '../diagnostics/diagnostic_listener.dart';
 import '../elements/elements.dart';
 import '../elements/entities.dart' show Entity, Local;
 import '../elements/resolution_types.dart';
 import '../js_backend/js_backend.dart';
+import '../options.dart';
 import '../resolution/tree_elements.dart';
 import '../types/types.dart';
 import '../world.dart' show ClosedWorld;
 import 'jump_handler.dart';
 import 'locals_handler.dart';
 import 'nodes.dart';
 import 'type_builder.dart';
 
 /// Base class for objects that build up an SSA graph.
 ///
@@ skipping 17 matching lines @@
 
   /// The JavaScript backend we are targeting in this compilation.
   JavaScriptBackend get backend;
 
   CodegenRegistry get registry;
 
   ClosedWorld get closedWorld;
 
   CommonMasks get commonMasks => closedWorld.commonMasks;
 
+  DiagnosticReporter get reporter => backend.reporter;
+
+  CompilerOptions get options => compiler.options;

[Emily Fortuna, 2017/04/10 19:34:02]

this works, but why not just pass CompilerOptions in when the SsaBuilder and
KernelSsaBuilder are constructed like you've been doing in other parts of the
codebase?

[Johnni Winther, 2017/04/11 07:13:31]

This is the plan. I just take small steps.

+
+  CommonElements get commonElements => closedWorld.commonElements;
+
   GlobalTypeInferenceResults get globalInferenceResults =>
       compiler.globalInference.results;
 
   /// Used to track the locals while building the graph.
   LocalsHandler localsHandler;
 
   /// A stack of instructions.
   ///
   /// We build the SSA graph by simulating a stack machine.
   List<HInstruction> stack = <HInstruction>[];
@@ skipping 168 matching lines @@
     open(newBlock);
   }
 
   HInstruction callSetRuntimeTypeInfo(
       HInstruction typeInfo, HInstruction newObject);
 
   /// The element for which this SSA builder is being used.
   Element get targetElement;
   TypeBuilder get typeBuilder;
 }