Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2813593002: Add editing of dimensions on retry (Closed)

Created:
3 years, 8 months ago by kjlubick
Modified:
3 years, 8 months ago
Reviewers:
KevinL, stephana, rmistry
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : build #

Total comments: 6

Patch Set 3 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -82 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 2 6 chunks +52 lines, -41 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page.html View 1 2 7 chunks +63 lines, -40 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page-demo.html View 1 chunk +1 line, -1 line 0 comments Download
A appengine/swarming/ui/res/imp/taskpage/task-retry-prompt.html View 1 2 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
kjlubick
https://screencast.googleplex.com/cast/NTE1OTkzMTEyODg0MDE5MnxjMmJhM2Q3NC05OA See live at https://2736-15283a5-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/task?id=3570b7880eac1410&refresh=10&show_raw=1
3 years, 8 months ago (2017-04-10 12:58:38 UTC) #3
kjlubick
3 years, 8 months ago (2017-04-10 13:22:42 UTC) #5
rmistry
LGTM https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/res/imp/taskpage/task-page.html File appengine/swarming/ui/res/imp/taskpage/task-page.html (right): https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/res/imp/taskpage/task-page.html#newcode943 appengine/swarming/ui/res/imp/taskpage/task-page.html:943: sk.errorMessage("Your retried task much specify dimensions", 5000); much ...
3 years, 8 months ago (2017-04-10 14:36:39 UTC) #6
stephana
lgtm https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/res/imp/taskpage/task-retry-prompt.html File appengine/swarming/ui/res/imp/taskpage/task-retry-prompt.html (right): https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/res/imp/taskpage/task-retry-prompt.html#newcode104 appengine/swarming/ui/res/imp/taskpage/task-retry-prompt.html:104: this.set("task_dimensions."+e.model.index+".value", e.currentTarget.value) nit: consider breaking up line.
3 years, 8 months ago (2017-04-10 14:54:05 UTC) #7
kjlubick
https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/res/imp/taskpage/task-page.html File appengine/swarming/ui/res/imp/taskpage/task-page.html (right): https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/res/imp/taskpage/task-page.html#newcode943 appengine/swarming/ui/res/imp/taskpage/task-page.html:943: sk.errorMessage("Your retried task much specify dimensions", 5000); On 2017/04/10 ...
3 years, 8 months ago (2017-04-10 15:02:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813593002/40001
3 years, 8 months ago (2017-04-10 15:02:45 UTC) #11
KevinL
lgtm
3 years, 8 months ago (2017-04-10 15:02:52 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 15:06:27 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/2990d72830c4a1580e273b6074d300b420f0035a

Powered by Google App Engine
This is Rietveld 408576698