Add editing of dimensions on retry

Add editing of dimensions on retry

BUG=693629
Review-Url: https://codereview.chromium.org/2813593002
Committed: https://github.com/luci/luci-py/commit/2990d72830c4a1580e273b6074d300b420f0035a

[kjlubick, 2017-04-10 12:37:27]

Description was changed from

==========
Add editing of dimensions on retry

BUG=
==========

to

==========
Add editing of dimensions on retry

BUG=693629
==========

[kjlubick, 2017-04-10 12:58:37]

kjlubick@google.com changed reviewers:
+ rmistry@google.com

[kjlubick, 2017-04-10 12:58:38]

https://screencast.googleplex.com/cast/NTE1OTkzMTEyODg0MDE5MnxjMmJhM2Q3NC05OA

See live at
https://2736-15283a5-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/task...

[kjlubick, 2017-04-10 13:22:42]

kjlubick@google.com changed reviewers:
+ stephana@google.com

[rmistry, 2017-04-10 14:36:39]

LGTM

https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/taskpage/task-page.html (right):

https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/taskpage/task-page.html:943: sk.errorMessage("Your
retried task much specify dimensions", 5000);
much -> must

https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/taskpage/task-page.html:991: miloFrame.src =
this._getDisplayServerLink(this._server_details.display_server_url_template,this.task_id);
Nit: Breakup the long line.

[stephana, 2017-04-10 14:54:05]

lgtm

https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/taskpage/task-retry-prompt.html (right):

https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/taskpage/task-retry-prompt.html:104:
this.set("task_dimensions."+e.model.index+".value", e.currentTarget.value)
nit: consider breaking up line.

[kjlubick, 2017-04-10 15:02:36]

https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/taskpage/task-page.html (right):

https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/taskpage/task-page.html:943: sk.errorMessage("Your
retried task much specify dimensions", 5000);
On 2017/04/10 at 14:36:39, rmistry wrote:
> much -> must

http://i3.kym-cdn.com/photos/images/facebook/000/581/722/7bc.jpg

https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/taskpage/task-page.html:991: miloFrame.src =
this._getDisplayServerLink(this._server_details.display_server_url_template,this.task_id);
On 2017/04/10 at 14:36:39, rmistry wrote:
> Nit: Breakup the long line.

Done.

https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/taskpage/task-retry-prompt.html (right):

https://codereview.chromium.org/2813593002/diff/20001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/taskpage/task-retry-prompt.html:104:
this.set("task_dimensions."+e.model.index+".value", e.currentTarget.value)
On 2017/04/10 at 14:54:05, stephana wrote:
> nit: consider breaking up line.

Done.

[kjlubick, 2017-04-10 15:02:38]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2017-04-10 15:02:38]

The patchset sent to the CQ was uploaded after l-g-t-m from stephana@google.com,
rmistry@google.com
Link to the patchset: https://codereview.chromium.org/2813593002/#ps40001
(title: "Address feedback")

[commit-bot: I haz the power, 2017-04-10 15:02:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[KevinL, 2017-04-10 15:02:51]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2017-04-10 15:02:52]

lgtm

[commit-bot: I haz the power, 2017-04-10 15:06:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491836558383500,
"parent_rev": "6cbb33804ef0fcb61b80ba4cb5976dc36052748b", "commit_rev":
"2990d72830c4a1580e273b6074d300b420f0035a"}

[commit-bot: I haz the power, 2017-04-10 15:06:26]

Description was changed from

==========
Add editing of dimensions on retry

BUG=693629
==========

to

==========
Add editing of dimensions on retry

BUG=693629

Review-Url: https://codereview.chromium.org/2813593002
Committed:
https://github.com/luci/luci-py/commit/2990d72830c4a1580e273b6074d300b420f0035a
==========

[commit-bot: I haz the power, 2017-04-10 15:06:27]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/2990d72830c4a1580e273b6074d300b420f0035a