Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

Issue 2813583002: Support calc(...) in ConsumeAngleOrPercent / for conic-gradient (Closed)
Patch Set: Fix up IsAngle Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h
index a0c694e6b74dd6b92d2a4b438d94f508d3d8dbe2..ab683277c610681fdddbb27feb9fdd50369b0de5 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h
@@ -164,7 +164,7 @@ class CORE_EXPORT CSSPrimitiveValue : public CSSValue {
return unit == UnitType::kDegrees || unit == UnitType::kRadians ||
unit == UnitType::kGradians || unit == UnitType::kTurns;
}
- bool IsAngle() const { return IsAngle(GetType()); }
+ bool IsAngle() const { return IsAngle(TypeWithCalcResolved()); }
f(malita) 2017/04/10 14:16:26 All IsFoo() helpers seem to ignore calc values at
fs 2017/04/10 14:22:58 Hmm, IsLength, IsNumber and IsPercentage (the non-
bool IsFontRelativeLength() const {
return GetType() == UnitType::kQuirkyEms || GetType() == UnitType::kEms ||
GetType() == UnitType::kExs || GetType() == UnitType::kRems ||

Powered by Google App Engine
This is Rietveld 408576698