Add a new set of commands to resize and position windows

Add a new set of commands to resize and position windows

https://docs.google.com/document/d/1Q0kuHgU1d-sj8gePjEU9nHtlQzz5rNvvGH8fCJ3iBq4/edit?usp=sharing

Devtools side, add a new UI domain and methods:
method: getWindowForTarget, param: targetID, return: windowID, bounds.
method: setWindowBounds, param: windowID, bounds
method: getWindowBounds, param: windowID, return: bounds

bounds object: left, top, width, height, window_state (minimized, maximized, fullscreen, normal)

BUG=604324
Review-Url: https://codereview.chromium.org/2813553005
Cr-Commit-Position: refs/heads/master@{#464265}
Committed: https://chromium.googlesource.com/chromium/src/+/dd0fef609820bee5b4e9b6aa46dd4ee3dd53f81f

[jzfeng, 2017-04-11 05:38:57]

The CQ bit was checked by jzfeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 05:39:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jzfeng, 2017-04-11 06:26:02]

jzfeng@chromium.org changed reviewers:
+ dgozman@chromium.org

[jzfeng, 2017-04-11 06:26:02]

Hi Dmitry,

I tried to fix the flaky tests on mac 10.10. But all the attempts didn't work,
the test failed most of the time, even for the simplest test case (See
NormalToMinimizedWindow test in patch 3: window()->Minimize(), wait for at most
5 seconds, window->IsMinimized() is still false.)

So I decide to disable the flaky tests on mac.

PTAL.

Thanks!

[commit-bot: I haz the power, 2017-04-11 07:45:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 07:45:35]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-11 18:16:16]

On 2017/04/11 06:26:02, jzfeng wrote:
> Hi Dmitry,
> 
> I tried to fix the flaky tests on mac 10.10. But all the attempts didn't work,
> the test failed most of the time, even for the simplest test case (See
> NormalToMinimizedWindow test in patch 3: window()->Minimize(), wait for at
most
> 5 seconds, window->IsMinimized() is still false.)
> 
> So I decide to disable the flaky tests on mac.
> 
> PTAL.
> 
> Thanks!

Thank you for explanation. The fact that tests for automation do not work is
worrisome. After all,
our tests are not different from the automation tests which will use this
functionality.
I'd say we should spend a bit more time to understand what's broken:
- maybe this just does not work on Mac 10.10, which means we should either not
allow this functionality or fix it so it does work;
- maybe it's the browser tests setup which does not work, and e.g. using
interactive ui tests could help;
- maybe we implemented it incorrectly, while it works for extension APIs and it
makes sense to look into their tests.

[jzfeng, 2017-04-12 04:23:13]

The CQ bit was checked by jzfeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 04:23:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 05:52:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 05:52:06]

Dry run: This issue passed the CQ dry run.

[jzfeng, 2017-04-12 07:41:11]

It turns out that the reason is the browser tests setup. Here is the bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=660582.

I moved all the tests to interactive ui tests and ran mac_chromium_10.10_rel_ng
twice, there are no failures.

PTAL.

[dgozman, 2017-04-12 18:38:29]

On 2017/04/12 07:41:11, jzfeng wrote:
> It turns out that the reason is the browser tests setup. Here is the bug:
> https://bugs.chromium.org/p/chromium/issues/detail?id=660582.
> 
> I moved all the tests to interactive ui tests and ran
mac_chromium_10.10_rel_ng
> twice, there are no failures.

Very nice! lgtm

[jzfeng, 2017-04-13 00:42:31]

The CQ bit was checked by jzfeng@chromium.org

[commit-bot: I haz the power, 2017-04-13 00:43:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 02:59:23]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492044151101280,
"parent_rev": "468178c6ee34ad0880f8fa21dd3d46a8a9657cac", "commit_rev":
"dd0fef609820bee5b4e9b6aa46dd4ee3dd53f81f"}

[commit-bot: I haz the power, 2017-04-13 03:00:18]

Description was changed from

==========
Add a new set of commands to resize and position windows

https://docs.google.com/document/d/1Q0kuHgU1d-sj8gePjEU9nHtlQzz5rNvvGH8fCJ3iB...

Devtools side, add a new UI domain and methods:
method: getWindowForTarget, param: targetID, return: windowID, bounds.
method: setWindowBounds, param: windowID, bounds
method: getWindowBounds, param: windowID, return: bounds

bounds object: left, top, width, height, window_state (minimized, maximized,
fullscreen, normal)

BUG=604324
==========

to

==========
Add a new set of commands to resize and position windows

https://docs.google.com/document/d/1Q0kuHgU1d-sj8gePjEU9nHtlQzz5rNvvGH8fCJ3iB...

Devtools side, add a new UI domain and methods:
method: getWindowForTarget, param: targetID, return: windowID, bounds.
method: setWindowBounds, param: windowID, bounds
method: getWindowBounds, param: windowID, return: bounds

bounds object: left, top, width, height, window_state (minimized, maximized,
fullscreen, normal)

BUG=604324

Review-Url: https://codereview.chromium.org/2813553005
Cr-Commit-Position: refs/heads/master@{#464265}
Committed:
https://chromium.googlesource.com/chromium/src/+/dd0fef609820bee5b4e9b6aa46dd...
==========

[commit-bot: I haz the power, 2017-04-13 03:00:19]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/dd0fef609820bee5b4e9b6aa46dd...