Photo Picker Toolbar: Add UI controls showing which tile is selected.

Photo Picker Dialog: Add UI controls showing which tiles are selected.

Also fix background color being wrong for the special tiles 
and some minor whitespace issues in code.

BUG=656015
Review-Url: https://codereview.chromium.org/2813553003
Cr-Commit-Position: refs/heads/master@{#463434}
Committed: https://chromium.googlesource.com/chromium/src/+/7e5f99f2ae24ab7e04e9c944dc48cd2a7c46a0ad

[Finnur, 2017-04-10 11:27:53]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 11:28:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2017-04-10 11:29:19]

Description was changed from

==========
Photo Picker Toolbar: Add UI controls showing which tile is selected.

BUG=656015
==========

to

==========
Photo Picker Toolbar: Add UI controls showing which tile is selected.

Also fix background color being wrong for special tile 
and some minor whitespace issues in code.

BUG=656015
==========

[Finnur, 2017-04-10 11:29:19]

finnur@chromium.org changed reviewers:
+ twellington@chromium.org

[Finnur, 2017-04-10 11:40:45]

Patchset #2 (id:20001) has been deleted

[Finnur, 2017-04-10 11:43:55]

Description was changed from

==========
Photo Picker Toolbar: Add UI controls showing which tile is selected.

Also fix background color being wrong for special tile 
and some minor whitespace issues in code.

BUG=656015
==========

to

==========
Photo Picker Toolbar: Add UI controls showing which tile is selected.

Also fix background color being wrong for the special tiles 
and some minor whitespace issues in code.

BUG=656015
==========

[Finnur, 2017-04-10 11:44:13]

Patchset #2 (id:40001) has been deleted

[Finnur, 2017-04-10 11:45:16]

https://codereview.chromium.org/2813553003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
(right):

https://codereview.chromium.org/2813553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java:243:
setBackgroundColor(ApiCompatibilityUtils.getColor(resources, bgColorId));
This fixes the background color problem with the special tile. After some of the
XML changes I made in the previous CL this stopped working and I didn't notice
until after I got the LGTM from you so I didn't want to hold the CL up for this.

https://codereview.chromium.org/2813553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java:270:
return mBitmapDetails == null || mBitmapDetails.type() == PickerBitmap.PICTURE;
This needs a bit of background...

When I trimmed down the CL (for easier review), a bug appeared where
mBitmapDetails can be null (hence the temporary null checks). I didn't worry
about this bug too much, because it doesn't seem to surface in the final CL so
my strategy is to ignore it unless it appears after I've checked in the stuff in
waiting.

Changing this line from != to == effectively just means that a tile must have
_some_ type and if mBitmapDetails is null then we assume it is a picture,
because those are most common.

These null checks will go away anyway before I'm done.

https://codereview.chromium.org/2813553003/diff/60001/chrome/android/java/res...
File chrome/android/java/res/layout/photo_picker_bitmap_view.xml (left):

https://codereview.chromium.org/2813553003/diff/60001/chrome/android/java/res...
chrome/android/java/res/layout/photo_picker_bitmap_view.xml:14:
android:background="@color/photo_picker_tile_bg_color">
Not needed. Will be set programmatically instead.

[Finnur, 2017-04-10 15:36:10]

Description was changed from

==========
Photo Picker Toolbar: Add UI controls showing which tile is selected.

Also fix background color being wrong for the special tiles 
and some minor whitespace issues in code.

BUG=656015
==========

to

==========
Photo Picker Dialog: Add UI controls showing which tile is selected.

Also fix background color being wrong for the special tiles 
and some minor whitespace issues in code.

BUG=656015
==========

[Finnur, 2017-04-10 15:36:26]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 15:36:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2017-04-10 15:37:08]

Description was changed from

==========
Photo Picker Dialog: Add UI controls showing which tile is selected.

Also fix background color being wrong for the special tiles 
and some minor whitespace issues in code.

BUG=656015
==========

to

==========
Photo Picker Dialog: Add UI controls showing which tiles are selected.

Also fix background color being wrong for the special tiles 
and some minor whitespace issues in code.

BUG=656015
==========

[Theresa, 2017-04-10 16:26:58]

lgtm

[commit-bot: I haz the power, 2017-04-10 16:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:31:20]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Finnur, 2017-04-10 16:33:02]

finnur@chromium.org changed reviewers:
+ miguelg@chromium.org

[Finnur, 2017-04-10 16:36:39]

Patchset #3 (id:80001) has been deleted

[Finnur, 2017-04-10 16:37:01]

finnur@chromium.org changed reviewers:
- miguelg@chromium.org

[Finnur, 2017-04-10 16:37:41]

Oops, meant to say: I added myself as owner for this dir and removed a dead var.
Can I bother you to take another look and if all is OK, press the CQ button?

[Theresa, 2017-04-10 18:06:36]

On 2017/04/10 16:37:41, Finnur wrote:
> Oops, meant to say: I added myself as owner for this dir and removed a dead
var.
> Can I bother you to take another look and if all is OK, press the CQ button?

Can you add me to the OWNERS file too please? And for now, for large UI changes,
please get a review from me or someone else on the front-end team.

Otherwise, still lgtm

[Finnur, 2017-04-10 21:21:36]

> Can you add me to the OWNERS file too please? 

Yup, good idea.

> And for now, for large UI changes,
> please get a review from me or someone else on the front-end team.

Yup, you'd be first on my list for a review, probably followed by Ted. :)

> Otherwise, still lgtm

Thanks! Checking in.

[Finnur, 2017-04-10 21:21:43]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2017-04-10 21:21:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2813553003/#ps120001
(title: "Add Theresa as owner")

[commit-bot: I haz the power, 2017-04-10 21:22:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 23:04:58]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1491859303176610,
"parent_rev": "4b4a31d9f95869f6efc1fee07942eb913140ae5d", "commit_rev":
"7e5f99f2ae24ab7e04e9c944dc48cd2a7c46a0ad"}

[commit-bot: I haz the power, 2017-04-10 23:06:09]

Description was changed from

==========
Photo Picker Dialog: Add UI controls showing which tiles are selected.

Also fix background color being wrong for the special tiles 
and some minor whitespace issues in code.

BUG=656015
==========

to

==========
Photo Picker Dialog: Add UI controls showing which tiles are selected.

Also fix background color being wrong for the special tiles 
and some minor whitespace issues in code.

BUG=656015

Review-Url: https://codereview.chromium.org/2813553003
Cr-Commit-Position: refs/heads/master@{#463434}
Committed:
https://chromium.googlesource.com/chromium/src/+/7e5f99f2ae24ab7e04e9c944dc48...
==========

[commit-bot: I haz the power, 2017-04-10 23:06:16]

Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/7e5f99f2ae24ab7e04e9c944dc48...