Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2813533002: Reenable DevToolsSanityTest.TestToolboxLoadedUndocked on Linux (Closed)

Created:
3 years, 8 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 8 months ago
Reviewers:
nainar, dgozman
CC:
chromium-reviews, devtools-reviews_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable DevToolsSanityTest.TestToolboxLoadedUndocked on Linux Reenabling test, unable to repro reported failure. BUG=702641 Review-Url: https://codereview.chromium.org/2813533002 Cr-Commit-Position: refs/heads/master@{#466202} Committed: https://chromium.googlesource.com/chromium/src/+/b6d0e27887ff5b622a03ac53d4343cc913365282

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
suzyh_UTC10 (ex-contributor)
3 years, 8 months ago (2017-04-10 09:30:39 UTC) #7
nainar
lgtm if you can't repro failure.
3 years, 8 months ago (2017-04-10 17:18:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813533002/1
3 years, 8 months ago (2017-04-10 23:14:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/407337)
3 years, 8 months ago (2017-04-10 23:25:19 UTC) #12
suzyh_UTC10 (ex-contributor)
Whoops, need a reviewer with OWNERS. +pfeldman PTAL
3 years, 8 months ago (2017-04-10 23:43:48 UTC) #14
suzyh_UTC10 (ex-contributor)
Ping pfeldman: PTAL
3 years, 8 months ago (2017-04-18 06:04:48 UTC) #15
suzyh_UTC10 (ex-contributor)
Redirecting to dgozman: Would you mind taking a look at this one too? Thanks!
3 years, 8 months ago (2017-04-20 06:33:13 UTC) #17
dgozman
lgtm
3 years, 8 months ago (2017-04-20 16:43:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813533002/1
3 years, 8 months ago (2017-04-20 23:57:08 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 00:41:09 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6d0e27887ff5b622a03ac53d434...

Powered by Google App Engine
This is Rietveld 408576698