Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2813523002: Remove stray DO NOT SUMBITS left after blink rename (Closed)

Created:
3 years, 8 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 8 months ago
CC:
Mads Ager (chromium), blink-reviews, chromium-reviews, haraken, kinuko+watch, kouhei+heap_chromium.org, oilpan-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stray DO NOT SUMBITS left after blink rename BUG= Review-Url: https://codereview.chromium.org/2813523002 Cr-Commit-Position: refs/heads/master@{#463201} Committed: https://chromium.googlesource.com/chromium/src/+/d1b03874a28beb1de1182849fa72a4db600c64e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M third_party/WebKit/Source/core/editing/commands/EditorCommandNames.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGC.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
alex clarke (OOO till 29th)
PTAL
3 years, 8 months ago (2017-04-10 07:52:04 UTC) #4
jochen (gone - plz use gerrit)
can you please file a bug for these, and assign it to dcheng@ to investigate? ...
3 years, 8 months ago (2017-04-10 07:56:59 UTC) #5
alex clarke (OOO till 29th)
On 2017/04/10 07:56:59, jochen wrote: > can you please file a bug for these, and ...
3 years, 8 months ago (2017-04-10 08:02:08 UTC) #6
dcheng
LGTM
3 years, 8 months ago (2017-04-10 08:07:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813523002/1
3 years, 8 months ago (2017-04-10 08:30:26 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 09:25:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d1b03874a28beb1de1182849fa72...

Powered by Google App Engine
This is Rietveld 408576698