Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2813503004: Change a few LazyInstances in printing code to be Leaky. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change a few LazyInstances in printing code to be Leaky. BUG=698982 Review-Url: https://codereview.chromium.org/2813503004 Cr-Commit-Position: refs/heads/master@{#463526} Committed: https://chromium.googlesource.com/chromium/src/+/6c884e6488c882cf15b6332541f1437050265aed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/printing/print_view_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M printing/print_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printed_document.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
3 years, 8 months ago (2017-04-11 03:23:15 UTC) #6
scottmg
lgtm
3 years, 8 months ago (2017-04-11 03:35:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813503004/1
3 years, 8 months ago (2017-04-11 03:46:08 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 04:07:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c884e6488c882cf15b6332541f1...

Powered by Google App Engine
This is Rietveld 408576698