Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2813503003: [ObjC ARC] Converts ios/chrome/browser/web:unit_tests_internal to ARC. (Closed)

Created:
3 years, 8 months ago by Olivier
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/web:unit_tests_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2813503003 Cr-Commit-Position: refs/heads/master@{#468668} Committed: https://chromium.googlesource.com/chromium/src/+/83ea69eccb3bdecf0374a17fbe789ca04754d136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -23 lines) Patch
M ios/chrome/browser/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/web/auto_reload_controller_unittest.mm View 3 chunks +9 lines, -7 lines 0 comments Download
M ios/chrome/browser/web/blocked_popup_tab_helper_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/web/chrome_web_client_unittest.mm View 2 chunks +4 lines, -1 line 0 comments Download
M ios/chrome/browser/web/error_page_generator_unittest.mm View 6 chunks +15 lines, -15 lines 0 comments Download
M ios/chrome/browser/web/external_app_launcher_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Olivier
3 years, 8 months ago (2017-04-10 13:41:47 UTC) #6
stkhapugin
lgtm
3 years, 8 months ago (2017-04-10 14:52:50 UTC) #7
Olivier
eugenebut@chromium.org: Please review changes in
3 years, 8 months ago (2017-04-10 15:10:07 UTC) #9
pkl (ping after 24h if needed)
+marq for OWNERS review since eugenebut is out till next Monday.
3 years, 7 months ago (2017-05-02 13:55:03 UTC) #11
marq (ping after 24h)
lgtm LGTM, and I'll CQ because Olivier is also OOO.
3 years, 7 months ago (2017-05-02 14:12:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813503003/1
3 years, 7 months ago (2017-05-02 14:12:47 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 16:21:01 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83ea69eccb3bdecf0374a17fbe78...

Powered by Google App Engine
This is Rietveld 408576698