Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2813463002: Factor out code to set up editing-related context menu items to a static function. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Factor out code to set up editing-related context menu items to a static function. Introduces ContextMenuClientImpl::ComputeEditFlags() to set WebContextMenuData::edit_flags up. This CL will make unit-testing easier. This CL has no behavior changes. BUG=686339 Review-Url: https://codereview.chromium.org/2813463002 Cr-Commit-Position: refs/heads/master@{#463171} Committed: https://chromium.googlesource.com/chromium/src/+/adc8910776c64a876f0422454da618a37d01167b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -21 lines) Patch
M third_party/WebKit/Source/web/ContextMenuClientImpl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 2 chunks +29 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tkent
yosin@, would you review this please? I have a plan to add unit test for ...
3 years, 8 months ago (2017-04-10 03:44:54 UTC) #7
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-10 04:22:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813463002/1
3 years, 8 months ago (2017-04-10 04:42:53 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 04:48:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/adc8910776c64a876f0422454da6...

Powered by Google App Engine
This is Rietveld 408576698