Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2813443003: Revert of RTCRtpReceiver.getContributingSources() added. (Closed)

Created:
3 years, 8 months ago by hbos_chromium
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, feature-media-reviews_chromium.org, haraken, jam, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-content_chromium.org, Peter Beverloo, posciak+watch_chromium.org, tommyw+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of RTCRtpReceiver.getContributingSources() added. (patchset #8 id:160001 of https://codereview.chromium.org/2803693002/ ) Reason for revert: The dependent CL was reverted due to suspected of: https://bugs.chromium.org/p/webrtc/issues/detail?id=7465 Original issue's description: > RTCRtpReceiver.getContributingSources() added. > > Adds RTCRtpReceiver.getContributingSources(), > https://w3c.github.io/webrtc-pc/#dom-rtcrtpreceiver-getcontributingsources, > and RTCRtpContributingSource, > https://w3c.github.io/webrtc-pc/#dom-rtcrtpcontributingsource, > behind flag "RuntimeEnabled=RTCRtpReceiver". > > Contributing sources come in two flavors, SSRCs and CSRCs. This > interface represents both. For now we ignore SSRCs and only return > CSRCs. It was recently decided that SSRCs would be returned in a > separate method to distinguish between the two cases. > > A LayoutTest is used to thoroughly test all blink functionality with > regards to CSRCs and the caching of contributing sources. This uses > mocking to update contributing sources in a predictable way. > > The browsertest verifies that no contributing sources are used in a > normal peerconnection call. The multiple CSRCs case is currently not > possible to test in a browsertest so we rely on the LayoutTest (and > webrtc layer testing of contributing sources). > > BUG=703122 > > Review-Url: https://codereview.chromium.org/2803693002 > Cr-Commit-Position: refs/heads/master@{#463199} > Committed: https://chromium.googlesource.com/chromium/src/+/7a16f508ad712bc38ff72e979dd5155a4015c320 TBR=jochen@chromium.org,deadbeef@chromium.org,foolip@chromium.org,guidou@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=703122 Review-Url: https://codereview.chromium.org/2813443003 Cr-Commit-Position: refs/heads/master@{#463226} Committed: https://chromium.googlesource.com/chromium/src/+/5209c4a740829998e6f5d78f0771d1fac8d20689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -488 lines) Patch
M chrome/test/data/webrtc/peerconnection_rtp.js View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/renderer/media/webrtc/rtc_rtp_contributing_source.h View 1 chunk +0 lines, -34 lines 0 comments Download
D content/renderer/media/webrtc/rtc_rtp_contributing_source.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M content/renderer/media/webrtc/rtc_rtp_receiver.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/webrtc/rtc_rtp_receiver.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M content/shell/test_runner/mock_webrtc_peer_connection_handler.cc View 3 chunks +1 line, -66 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getReceivers.html View 2 chunks +1 line, -102 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/modules/peerconnection/RTCRtpContributingSource.h View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/modules/peerconnection/RTCRtpContributingSource.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/Source/modules/peerconnection/RTCRtpContributingSource.idl View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCRtpReceiver.h View 2 chunks +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCRtpReceiver.cpp View 2 chunks +0 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCRtpReceiver.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/exported/WebRTCRtpContributingSource.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/public/platform/WebRTCRtpContributingSource.h View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCRtpReceiver.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hbos_chromium
Created Revert of RTCRtpReceiver.getContributingSources() added.
3 years, 8 months ago (2017-04-10 12:01:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813443003/1
3 years, 8 months ago (2017-04-10 12:02:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5209c4a740829998e6f5d78f0771d1fac8d20689
3 years, 8 months ago (2017-04-10 12:04:06 UTC) #6
hbos_chromium
3 years, 8 months ago (2017-04-10 14:42:19 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2808113002/ by hbos@chromium.org.

The reason for reverting is: Reland. The dependent CL relanded, it was not the
culprit of https://bugs.chromium.org/p/webrtc/issues/detail?id=7465..

Powered by Google App Engine
This is Rietveld 408576698